mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
47 lines
1.4 KiB
JavaScript
47 lines
1.4 KiB
JavaScript
// Flags: --permission --allow-fs-read=* --allow-fs-write=*
|
|
'use strict';
|
|
|
|
const common = require('../common');
|
|
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
const assert = require('assert');
|
|
const path = require('path');
|
|
const { symlinkSync, symlink, promises: { symlink: symlinkAsync } } = require('fs');
|
|
|
|
const error = {
|
|
code: 'ERR_ACCESS_DENIED',
|
|
message: /relative symbolic link target/,
|
|
};
|
|
|
|
for (const targetString of ['a', './b/c', '../d', 'e/../f', 'C:drive-relative', 'ntfs:alternate']) {
|
|
for (const target of [targetString, Buffer.from(targetString)]) {
|
|
for (const path of [__filename, __dirname, process.execPath]) {
|
|
assert.throws(() => symlinkSync(target, path), error);
|
|
symlink(target, path, common.mustCall((err) => {
|
|
assert(err);
|
|
assert.strictEqual(err.code, error.code);
|
|
assert.match(err.message, error.message);
|
|
}));
|
|
assert.rejects(() => symlinkAsync(target, path), error).then(common.mustCall());
|
|
}
|
|
}
|
|
}
|
|
|
|
// Absolute should not throw
|
|
for (const targetString of [path.resolve('.')]) {
|
|
for (const target of [targetString, Buffer.from(targetString)]) {
|
|
for (const path of [__filename]) {
|
|
symlink(target, path, common.mustCall((err) => {
|
|
assert(err);
|
|
assert.strictEqual(err.code, 'EEXIST');
|
|
assert.match(err.message, /file already exists/);
|
|
}));
|
|
}
|
|
}
|
|
}
|