node/test/parallel/test-net-socket-no-halfopen-enforcer.js
Luigi Pinca 4e86f9b5ab net: do not inherit the no-half-open enforcer
`Socket.prototype.destroySoon()` is called as soon as `UV_EOF` is read
if the `allowHalfOpen` option is disabled. This already works as a
"no-half-open enforcer" so there is no need to inherit another from
`stream.Duplex`.

PR-URL: https://github.com/nodejs/node/pull/18974
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chen Gang <gangc.cxy@foxmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-03-07 16:05:30 +01:00

12 lines
322 B
JavaScript

'use strict';
require('../common');
// This test ensures that `net.Socket` does not inherit the no-half-open
// enforcer from `stream.Duplex`.
const { Socket } = require('net');
const { strictEqual } = require('assert');
const socket = new Socket({ allowHalfOpen: false });
strictEqual(socket.listenerCount('end'), 1);