mirror of
https://github.com/nodejs/node.git
synced 2025-05-02 13:11:36 +00:00

There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
21 lines
482 B
JavaScript
21 lines
482 B
JavaScript
'use strict';
|
|
const common = require('../common');
|
|
|
|
common.skipIfInspectorDisabled();
|
|
|
|
const { Session } = require('inspector');
|
|
const { Worker, isMainThread, workerData } = require('worker_threads');
|
|
|
|
if (!workerData && !isMainThread) {
|
|
common.skip('This test only works on a main thread');
|
|
}
|
|
|
|
if (isMainThread) {
|
|
new Worker(__filename, { workerData: {} });
|
|
} else {
|
|
const session = new Session();
|
|
session.connectToMainThread();
|
|
// Do not crash
|
|
session.disconnect();
|
|
}
|