mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 21:46:48 +00:00
8c597df350
When using the compatibility API the connection header is from now on ignored instead of throwing an `ERR_HTTP2_INVALID_CONNECTION_HEADERS` error. This logs a warning in such case to notify the user about the ignored header. PR-URL: https://github.com/nodejs/node/pull/23908 Fixes: https://github.com/nodejs/node/issues/23748 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const http2 = require('http2');
|
|
const body =
|
|
'<html><head></head><body><h1>this is some data</h2></body></html>';
|
|
|
|
const server = http2.createServer((req, res) => {
|
|
res.setHeader('foobar', 'baz');
|
|
res.setHeader('X-POWERED-BY', 'node-test');
|
|
res.setHeader('connection', 'connection-test');
|
|
res.end(body);
|
|
});
|
|
|
|
server.listen(0, common.mustCall(() => {
|
|
const client = http2.connect(`http://localhost:${server.address().port}`);
|
|
const headers = { ':path': '/' };
|
|
const req = client.request(headers);
|
|
req.setEncoding('utf8');
|
|
req.on('response', common.mustCall(function(headers) {
|
|
assert.strictEqual(headers.foobar, 'baz');
|
|
assert.strictEqual(headers['x-powered-by'], 'node-test');
|
|
}));
|
|
|
|
let data = '';
|
|
req.on('data', (d) => data += d);
|
|
req.on('end', () => {
|
|
assert.strictEqual(body, data);
|
|
server.close();
|
|
client.close();
|
|
});
|
|
req.end();
|
|
}));
|
|
|
|
const compatMsg = 'The provided connection header is not valid, ' +
|
|
'the value will be dropped from the header and ' +
|
|
'will never be in use.';
|
|
|
|
common.expectWarning('UnsupportedWarning', compatMsg);
|
|
|
|
server.on('error', common.mustNotCall());
|