mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
60 lines
1.7 KiB
JavaScript
60 lines
1.7 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
if (!common.hasCrypto)
|
|
common.skip('missing crypto');
|
|
const assert = require('assert');
|
|
const h2 = require('http2');
|
|
|
|
// Http2ServerResponse.flushHeaders
|
|
|
|
let serverResponse;
|
|
|
|
const server = h2.createServer();
|
|
server.listen(0, common.mustCall(function() {
|
|
const port = server.address().port;
|
|
server.once('request', common.mustCall(function(request, response) {
|
|
assert.strictEqual(response.headersSent, false);
|
|
assert.strictEqual(response._header, false); // Alias for headersSent
|
|
response.flushHeaders();
|
|
assert.strictEqual(response.headersSent, true);
|
|
assert.strictEqual(response._header, true);
|
|
response.flushHeaders(); // Idempotent
|
|
|
|
assert.throws(() => {
|
|
response.writeHead(400, { 'foo-bar': 'abc123' });
|
|
}, {
|
|
code: 'ERR_HTTP2_HEADERS_SENT'
|
|
});
|
|
|
|
response.on('finish', common.mustCall(function() {
|
|
server.close();
|
|
process.nextTick(() => {
|
|
response.flushHeaders(); // Idempotent
|
|
});
|
|
}));
|
|
serverResponse = response;
|
|
}));
|
|
|
|
const url = `http://localhost:${port}`;
|
|
const client = h2.connect(url, common.mustCall(function() {
|
|
const headers = {
|
|
':path': '/',
|
|
':method': 'GET',
|
|
':scheme': 'http',
|
|
':authority': `localhost:${port}`
|
|
};
|
|
const request = client.request(headers);
|
|
request.on('response', common.mustCall(function(headers, flags) {
|
|
assert.strictEqual(headers['foo-bar'], undefined);
|
|
assert.strictEqual(headers[':status'], 200);
|
|
serverResponse.end();
|
|
}, 1));
|
|
request.on('end', common.mustCall(function() {
|
|
client.close();
|
|
}));
|
|
request.end();
|
|
request.resume();
|
|
}));
|
|
}));
|