mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
cc26957cc3
In parallel/test-fs-read-stream-concurrent-reads.js the number of data chunks used is being tested when few concurrent reads are performed. The number of chunks can fluctuate based on the number of concurrent reads as well as the data that was read in one shot. Accommodate these variations in the test. Fixes: https://github.com/nodejs/node/issues/22339 PR-URL: https://github.com/nodejs/node/pull/25415 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
48 lines
1.4 KiB
JavaScript
48 lines
1.4 KiB
JavaScript
'use strict';
|
||
const common = require('../common');
|
||
const fixtures = require('../common/fixtures');
|
||
const assert = require('assert');
|
||
const fs = require('fs');
|
||
|
||
// Test that concurrent file read streams don’t interfere with each other’s
|
||
// contents, and that the chunks generated by the reads only retain a
|
||
// 'reasonable' amount of memory.
|
||
|
||
// Refs: https://github.com/nodejs/node/issues/21967
|
||
|
||
const filename = fixtures.path('loop.js'); // Some small non-homogeneous file.
|
||
const content = fs.readFileSync(filename);
|
||
|
||
const N = 2000;
|
||
let started = 0;
|
||
let done = 0;
|
||
|
||
const arrayBuffers = new Set();
|
||
|
||
function startRead() {
|
||
++started;
|
||
const chunks = [];
|
||
fs.createReadStream(filename)
|
||
.on('data', (chunk) => {
|
||
chunks.push(chunk);
|
||
arrayBuffers.add(chunk.buffer);
|
||
})
|
||
.on('end', common.mustCall(() => {
|
||
if (started < N)
|
||
startRead();
|
||
assert.deepStrictEqual(Buffer.concat(chunks), content);
|
||
if (++done === N) {
|
||
const retainedMemory =
|
||
[...arrayBuffers].map((ab) => ab.byteLength).reduce((a, b) => a + b);
|
||
assert(retainedMemory / (N * content.length) <= 3,
|
||
`Retaining ${retainedMemory} bytes in ABs for ${N} ` +
|
||
`chunks of size ${content.length}`);
|
||
}
|
||
}));
|
||
}
|
||
|
||
// Don’t start the reads all at once – that way we would have to allocate
|
||
// a large amount of memory upfront.
|
||
for (let i = 0; i < 6; ++i)
|
||
startRead();
|