mirror of
https://github.com/nodejs/node.git
synced 2025-04-28 13:40:37 +00:00
df08779e0d
This commit removes `common.crashOnUnhandledRejection()` and adds `common.disableCrashOnUnhandledRejection()`. To reduce the risk of mistakes and make writing tests that involve promises simpler, always install the unhandledRejection hook in tests and provide a way to disable it for the rare cases where it's needed. PR-URL: https://github.com/nodejs/node/pull/21849 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
18 lines
388 B
JavaScript
18 lines
388 B
JavaScript
'use strict';
|
|
require('../common');
|
|
|
|
const assert = require('assert');
|
|
const { promises: fs } = require('fs');
|
|
const fixtures = require('../common/fixtures');
|
|
|
|
const fn = fixtures.path('empty.txt');
|
|
|
|
fs.readFile(fn)
|
|
.then(assert.ok);
|
|
|
|
fs.readFile(fn, 'utf8')
|
|
.then(assert.strictEqual.bind(this, ''));
|
|
|
|
fs.readFile(fn, { encoding: 'utf8' })
|
|
.then(assert.strictEqual.bind(this, ''));
|