node/test/parallel/test-cluster-net-listen-relative-path.js
James M Snell 8caa1dcee6 test: rely less on duplicative common test harness utilities
There are several cleanups here that are not just style nits...

1. The `common.isMainThread` was just a passthrough to the
   `isMainThread` export on the worker_thread module. It's
   use was inconsistent and just obfuscated the fact that
   the test file depend on the `worker_threads` built-in.
   By eliminating it we simplify the test harness a bit and
   make it clearer which tests depend on the worker_threads
   check.
2. The `common.isDumbTerminal` is fairly unnecesary since
   that just wraps a public API check.
3. Several of the `common.skipIf....` checks were inconsistently
   used and really don't need to be separate utility functions.

A key part of the motivation here is to work towards making more
of the tests more self-contained and less reliant on the common
test harness where possible.

PR-URL: https://github.com/nodejs/node/pull/56712
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2025-01-25 07:23:09 +00:00

53 lines
1.5 KiB
JavaScript

'use strict';
const common = require('../common');
if (common.isWindows) {
common.skip('On Windows named pipes live in their own ' +
'filesystem and don\'t have a ~100 byte limit');
}
const { isMainThread } = require('worker_threads');
if (!isMainThread) {
common.skip('process.chdir is not available in Workers');
}
const assert = require('assert');
const cluster = require('cluster');
const fs = require('fs');
const net = require('net');
const path = require('path');
const tmpdir = require('../common/tmpdir');
// Choose a socket name such that the absolute path would exceed 100 bytes.
const socketDir = './unix-socket-dir';
const socketName = 'A'.repeat(101 - socketDir.length);
// Make sure we're not in a weird environment.
assert.ok(path.resolve(socketDir, socketName).length > 100,
'absolute socket path should be longer than 100 bytes');
if (cluster.isPrimary) {
// Ensure that the worker exits peacefully.
tmpdir.refresh();
process.chdir(tmpdir.path);
fs.mkdirSync(socketDir);
cluster.fork().on('exit', common.mustCall((statusCode) => {
assert.strictEqual(statusCode, 0);
assert.ok(!fs.existsSync(path.join(socketDir, socketName)),
'Socket should be removed when the worker exits');
}));
} else {
process.chdir(socketDir);
const server = net.createServer(common.mustNotCall());
server.listen(socketName, common.mustCall(() => {
assert.ok(fs.existsSync(socketName), 'Socket created in CWD');
process.disconnect();
}));
}