mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
7e08ccad17
This commit updates test/parallel/test-child-process-windows-hide.js to use node:test. This allows the test to use the built in mocking functionality instead of managing spies manually. It also prevents multiple child processes from being spawned in parallel, which can be problematic in the CI. PR-URL: https://github.com/nodejs/node/pull/56437 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com>
51 lines
1.9 KiB
JavaScript
51 lines
1.9 KiB
JavaScript
// Flags: --expose-internals
|
|
'use strict';
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const cp = require('child_process');
|
|
const { test } = require('node:test');
|
|
const internalCp = require('internal/child_process');
|
|
const cmd = process.execPath;
|
|
const args = ['-p', '42'];
|
|
const options = { windowsHide: true };
|
|
|
|
// Since windowsHide isn't really observable, this test relies on monkey
|
|
// patching spawn() and spawnSync() to verify that the flag is being passed
|
|
// through correctly.
|
|
|
|
test('spawnSync() passes windowsHide correctly', (t) => {
|
|
const spy = t.mock.method(internalCp, 'spawnSync');
|
|
const child = cp.spawnSync(cmd, args, options);
|
|
|
|
assert.strictEqual(child.status, 0);
|
|
assert.strictEqual(child.signal, null);
|
|
assert.strictEqual(child.stdout.toString().trim(), '42');
|
|
assert.strictEqual(child.stderr.toString().trim(), '');
|
|
assert.strictEqual(spy.mock.calls.length, 1);
|
|
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
|
|
});
|
|
|
|
test('spawn() passes windowsHide correctly', (t, done) => {
|
|
const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
|
|
const child = cp.spawn(cmd, args, options);
|
|
|
|
child.on('exit', common.mustCall((code, signal) => {
|
|
assert.strictEqual(code, 0);
|
|
assert.strictEqual(signal, null);
|
|
assert.strictEqual(spy.mock.calls.length, 1);
|
|
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
|
|
done();
|
|
}));
|
|
});
|
|
|
|
test('execFile() passes windowsHide correctly', (t, done) => {
|
|
const spy = t.mock.method(internalCp.ChildProcess.prototype, 'spawn');
|
|
cp.execFile(cmd, args, options, common.mustSucceed((stdout, stderr) => {
|
|
assert.strictEqual(stdout.trim(), '42');
|
|
assert.strictEqual(stderr.trim(), '');
|
|
assert.strictEqual(spy.mock.calls.length, 1);
|
|
assert.strictEqual(spy.mock.calls[0].arguments[0].windowsHide, true);
|
|
done();
|
|
}));
|
|
});
|