mirror of
https://github.com/nodejs/node.git
synced 2025-04-30 07:19:19 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
64 lines
1.8 KiB
JavaScript
64 lines
1.8 KiB
JavaScript
'use strict';
|
|
// Flags: --expose-internals
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const getValidStdio = require('internal/child_process').getValidStdio;
|
|
|
|
const expectedError = { code: 'ERR_INVALID_ARG_VALUE', name: 'TypeError' };
|
|
|
|
// Should throw if string and not ignore, pipe, or inherit
|
|
assert.throws(() => getValidStdio('foo'), expectedError);
|
|
|
|
// Should throw if not a string or array
|
|
assert.throws(() => getValidStdio(600), expectedError);
|
|
|
|
// Should populate stdio with undefined if len < 3
|
|
{
|
|
const stdio1 = [];
|
|
const result = getValidStdio(stdio1, false);
|
|
assert.strictEqual(stdio1.length, 3);
|
|
assert.strictEqual(Object.hasOwn(result, 'stdio'), true);
|
|
assert.strictEqual(Object.hasOwn(result, 'ipc'), true);
|
|
assert.strictEqual(Object.hasOwn(result, 'ipcFd'), true);
|
|
}
|
|
|
|
// Should throw if stdio has ipc and sync is true
|
|
const stdio2 = ['ipc', 'ipc', 'ipc'];
|
|
assert.throws(() => getValidStdio(stdio2, true),
|
|
{ code: 'ERR_IPC_SYNC_FORK', name: 'Error' }
|
|
);
|
|
|
|
// Should throw if stdio is not a valid input
|
|
{
|
|
const stdio = ['foo'];
|
|
assert.throws(() => getValidStdio(stdio, false),
|
|
{ code: 'ERR_INVALID_SYNC_FORK_INPUT', name: 'TypeError' }
|
|
);
|
|
}
|
|
|
|
// Should throw if stdio is not a valid option
|
|
{
|
|
const stdio = [{ foo: 'bar' }];
|
|
assert.throws(() => getValidStdio(stdio), expectedError);
|
|
}
|
|
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (isMainThread) {
|
|
const stdio3 = [process.stdin, process.stdout, process.stderr];
|
|
const result = getValidStdio(stdio3, false);
|
|
assert.deepStrictEqual(result, {
|
|
stdio: [
|
|
{ type: 'fd', fd: 0 },
|
|
{ type: 'fd', fd: 1 },
|
|
{ type: 'fd', fd: 2 },
|
|
],
|
|
ipc: undefined,
|
|
ipcFd: undefined
|
|
});
|
|
} else {
|
|
common.printSkipMessage(
|
|
'stdio is not associated with file descriptors in Workers');
|
|
}
|