mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
e038d6a1cd
This completely refactors the `expectsError` behavior: so far it's almost identical to `assert.throws(fn, object)` in case it was used with a function as first argument. It had a magical property check that allowed to verify a functions `type` in case `type` was passed used in the validation object. This pattern is now completely removed and `assert.throws()` should be used instead. The main intent for `common.expectsError()` is to verify error cases for callback based APIs. This is now more flexible by accepting all validation possibilites that `assert.throws()` accepts as well. No magical properties exist anymore. This reduces surprising behavior for developers who are not used to the Node.js core code base. This has the side effect that `common` is used significantly less frequent. PR-URL: https://github.com/nodejs/node/pull/31092 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
38 lines
1.1 KiB
JavaScript
38 lines
1.1 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
|
|
// utf8, ucs2, ascii, latin1, utf16le
|
|
const encodings = ['utf8', 'utf-8', 'ucs2', 'ucs-2', 'ascii', 'latin1',
|
|
'binary', 'utf16le', 'utf-16le'];
|
|
|
|
encodings
|
|
.reduce((es, e) => es.concat(e, e.toUpperCase()), [])
|
|
.forEach((encoding) => {
|
|
assert.strictEqual(Buffer.from('foo', encoding).toString(encoding), 'foo');
|
|
});
|
|
|
|
// base64
|
|
['base64', 'BASE64'].forEach((encoding) => {
|
|
assert.strictEqual(Buffer.from('Zm9v', encoding).toString(encoding), 'Zm9v');
|
|
});
|
|
|
|
// hex
|
|
['hex', 'HEX'].forEach((encoding) => {
|
|
assert.strictEqual(Buffer.from('666f6f', encoding).toString(encoding),
|
|
'666f6f');
|
|
});
|
|
|
|
// Invalid encodings
|
|
for (let i = 1; i < 10; i++) {
|
|
const encoding = String(i).repeat(i);
|
|
const error = common.expectsError({
|
|
code: 'ERR_UNKNOWN_ENCODING',
|
|
name: 'TypeError',
|
|
message: `Unknown encoding: ${encoding}`
|
|
});
|
|
assert.ok(!Buffer.isEncoding(encoding));
|
|
assert.throws(() => Buffer.from('foo').toString(encoding), error);
|
|
}
|