mirror of
https://github.com/nodejs/node.git
synced 2025-04-29 06:19:07 +00:00
8caa1dcee6
There are several cleanups here that are not just style nits... 1. The `common.isMainThread` was just a passthrough to the `isMainThread` export on the worker_thread module. It's use was inconsistent and just obfuscated the fact that the test file depend on the `worker_threads` built-in. By eliminating it we simplify the test harness a bit and make it clearer which tests depend on the worker_threads check. 2. The `common.isDumbTerminal` is fairly unnecesary since that just wraps a public API check. 3. Several of the `common.skipIf....` checks were inconsistently used and really don't need to be separate utility functions. A key part of the motivation here is to work towards making more of the tests more self-contained and less reliant on the common test harness where possible. PR-URL: https://github.com/nodejs/node/pull/56712 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
45 lines
1.3 KiB
JavaScript
45 lines
1.3 KiB
JavaScript
'use strict';
|
|
|
|
const common = require('../common');
|
|
const assert = require('assert');
|
|
const tick = require('../common/tick');
|
|
const initHooks = require('./init-hooks');
|
|
const { checkInvocations } = require('./hook-checks');
|
|
const dns = require('dns');
|
|
const { isMainThread } = require('worker_threads');
|
|
|
|
if (!isMainThread) {
|
|
common.skip('Worker bootstrapping works differently -> different async IDs');
|
|
}
|
|
|
|
const hooks = initHooks();
|
|
|
|
hooks.enable();
|
|
dns.lookup('www.google.com', 4, common.mustCall(onlookup));
|
|
function onlookup() {
|
|
// We don't care about the error here in order to allow
|
|
// tests to run offline (lookup will fail in that case and the err be set);
|
|
|
|
const as = hooks.activitiesOfTypes('GETADDRINFOREQWRAP');
|
|
assert.strictEqual(as.length, 1);
|
|
|
|
const a = as[0];
|
|
assert.strictEqual(a.type, 'GETADDRINFOREQWRAP');
|
|
assert.strictEqual(typeof a.uid, 'number');
|
|
assert.strictEqual(a.triggerAsyncId, 1);
|
|
checkInvocations(a, { init: 1, before: 1 }, 'while in onlookup callback');
|
|
tick(2);
|
|
}
|
|
|
|
process.on('exit', onexit);
|
|
|
|
function onexit() {
|
|
hooks.disable();
|
|
hooks.sanityCheck('GETADDRINFOREQWRAP');
|
|
|
|
const as = hooks.activitiesOfTypes('GETADDRINFOREQWRAP');
|
|
const a = as[0];
|
|
checkInvocations(a, { init: 1, before: 1, after: 1, destroy: 1 },
|
|
'when process exits');
|
|
}
|