Ruben Bridgewater
d49580d812
benchmark: (child_process) use destructuring
...
PR-URL: https://github.com/nodejs/node/pull/18250
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-01-23 01:29:32 +01:00
Ruben Bridgewater
e167ab71fb
benchmark: var to const
...
PR-URL: https://github.com/nodejs/node/pull/13757
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2017-09-19 21:14:38 -03:00
Refael Ackermann
68c933c01e
test: fix flakyness with yes.exe
...
PR-URL: https://github.com/nodejs/node/pull/12821
Fixes: https://github.com/nodejs/node/issues/12817
Refs: https://github.com/nodejs/node/pull/12658
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-05-06 08:20:07 -04:00
Vse Mozhet Byt
0f69f40af0
benchmark: replace more [].join() with ''.repeat()
...
Refs: https://github.com/nodejs/node/pull/12170
PR-URL: https://github.com/nodejs/node/pull/12317
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-04-13 00:31:25 +03:00
Bartosz Sosnowski
cbbdc298b0
benchmark: fix child-process-read on Windows
...
Under Windows 'ipc' communication requires the other process to format
its messages with 'IPC framing protocol'. Otherwise, an assert is
triggered in libuv. This commit changes child-process-read benchmark
to use stdout to communicate with parent process. It also adds
child-process-read-ipc.js to benchmark IPC communication using
child node process.
PR-URL: https://github.com/nodejs/node/pull/6971
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2016-06-09 12:42:54 +01:00
Rich Trott
c9a5990a76
child_process: measure buffer length in bytes
...
This change fixes a known issue where `maxBuffer` limits by characters
rather than bytes. Benchmark added to confirm no performance regression
occurs with this change.
PR-URL: https://github.com/nodejs/node/pull/6764
Fixes: https://github.com/nodejs/node/issues/1901
Reviewed-By: Brian White <mscdex@mscdex.net>
2016-05-25 10:57:59 -07:00
Andreas Madsen
d9079ab801
benchmark: move misc to categorized directories
...
PR-URL: https://github.com/nodejs/node/pull/5177
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
2016-02-26 20:28:45 +11:00