Commit Graph

3 Commits

Author SHA1 Message Date
Antoine du Hamel
8f742bb13f
test: ensure never settling promises are detected
PR-URL: https://github.com/nodejs/node/pull/50318
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2023-10-23 17:55:50 +00:00
Daeyeon Jeong
db7fa9f4b7
test: allow numeric string for lookupService test
Fixes: https://github.com/nodejs/node/issues/42164

If the given port number isn't associated with any service name,
the `service` resolved from `dns.lookupService` can be a numeric
string representing the port number.

PR-URL: https://github.com/nodejs/node/pull/42596
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-04-12 13:27:05 +01:00
rickyes
ab22d2cdcb
test: rename test-lookupService-promises
PR-URL: https://github.com/nodejs/node/pull/33100
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2020-05-08 01:34:48 +02:00