Commit Graph

3 Commits

Author SHA1 Message Date
Rich Trott
acb36abf75 test: fix lint error
Fix lint error introduced 03550a5c1e. Unused module `fs` is removed.

PR-URL: https://github.com/nodejs/node/pull/16145
Ref: https://github.com/nodejs/node/pull/15832#issuecomment-335808467
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2017-10-11 06:42:08 -07:00
Feon Sua
03550a5c18 test:replace common.fixturesDir with commonfixtures
PR-URL: https://github.com/nodejs/node/pull/15832
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-10-11 17:23:10 +05:30
Bryan English
6f1caadb85 tls: prefer path over port in connect
Makes tls.connect() behave as documented, preferring options.path over
options.port. This makes it consistent with net.connect(), so the
included test demonstrates that both behave in this way.

Also, for consistency, noting the precedence of options.path in net
doc.

PR-URL: https://github.com/nodejs/node/pull/14564
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2017-09-22 16:30:24 -07:00