jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-22 06:02:44 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity
19,519 Commits 67 Branches 878 Tags 2.1 GiB
ee76f3153b
Commit Graph

3 Commits

Author SHA1 Message Date
Michael Dawson
6bc82daef0 n-api: use module name macro 
Update tests to use module name macro

PR-URL: https://github.com/nodejs/node/pull/16185
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2017-10-15 16:00:29 -07:00
Anna Henningsen
bdaa2cb585
test: add regression test for 5691 
With `CallbackScope`, this has become possible to do properly.

Fixes: https://github.com/nodejs/node/issues/5691
PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-09-14 17:38:45 +02:00
Anna Henningsen
64616bb769
src: refactor async callback handling 
- Merge the two almost-but-not-quite identical `MakeCallback()`
  implementations
- Provide a public `CallbackScope` class for embedders in order
  to enable `MakeCallback()`-like behaviour without tying that
  to calling a JS function

PR-URL: https://github.com/nodejs/node/pull/14697
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-09-14 17:38:44 +02:00