Commit Graph

3 Commits

Author SHA1 Message Date
Anatoli Papirovski
af2a104563
child_process: swallow errors in internal communication
Much like with NODE_HANDLE_ACK, the internal protocol for communication
about the sent socket should not expose its errors to the users when
those async calls are not initiated by them.

PR-URL: https://github.com/nodejs/node/pull/21108
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2018-06-07 09:43:10 -04:00
DavidCai
610ac7d858 test: increase coverage of internal/socket_list
PR-URL: https://github.com/nodejs/node/pull/12066
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2017-04-04 11:50:36 -07:00
DavidCai
4929d12e99 test: add internal/socket_list tests
PR-URL: https://github.com/nodejs/node/pull/11989
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-03-24 08:46:05 -07:00