Commit Graph

5 Commits

Author SHA1 Message Date
Luigi Pinca
0f9434af4d test: deflake test-http2-buffersize
This is basically a revert of
c452632d34.

The problem with that commit is that the promises returned by
`once(server, 'stream')` are all resolved with the same stream when the
first `'stream'` event is emitted.

Refs: https://github.com/nodejs/node/pull/39525#issuecomment-889080913

PR-URL: https://github.com/nodejs/node/pull/39591
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2021-08-02 18:42:44 +02:00
Tobias Nießen
30fb4a015d test: add common.mustSucceed
PR-URL: https://github.com/nodejs/node/pull/35086
Reviewed-By: Ruy Adorno <ruyadorno@github.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2020-10-17 00:48:26 +02:00
Rich Trott
c452632d34 test: refactor test-http2-buffersize
Remove seemlingly misplaced and/or extraneous comment. Replace countdown
with Promise.all.

PR-URL: https://github.com/nodejs/node/pull/32540
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2020-04-04 23:01:02 -07:00
Anna Henningsen
a5d4a397d6
test: make test-http2-buffersize more correct
Previously, this code could have closed the server before the
connection was actually received by the server, as the `'close'`
event on the client side can be emitted before the connection
is established.

The following commit exacerbates this problem, so fix the test first.

PR-URL: https://github.com/nodejs/node/pull/31502
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
2020-01-27 17:16:41 +00:00
Ouyang Yadong
33fbb93d2f http2: add Http2Stream.bufferSize
This commit adds `bufferSize` for `Http2Stream`.

Refs: https://github.com/nodejs/node/issues/21631

PR-URL: https://github.com/nodejs/node/pull/23711
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-11-05 22:00:35 -08:00