Commit Graph

93 Commits

Author SHA1 Message Date
Jeff Dickey
fd07bab7ae
build: added NINJA env to customize ninja binary
Fixes: https://github.com/nodejs/node/issues/44286
PR-URL: https://github.com/nodejs/node/pull/44293
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-08-22 11:39:00 +00:00
Michael Dawson
dcc9589e5e doc: add TypeScript execution requirements
Add section with high level approach/requirements for
enabling TypeScript execution as discussed in the Next-10
[TypeScript mini-summit](https://github.com/nodejs/next-10/pull/150)

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/44030
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-08-19 15:08:47 -04:00
Chengzhong Wu
c3770536bc
doc: update tags in adding-new-napi-api.md
The tag is now renamed as "node-api".

PR-URL: https://github.com/nodejs/node/pull/44190
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
2022-08-10 16:59:52 +00:00
Joyee Cheung
472edc775d
src: disambiguate terms used to refer to builtins and addons
The term "native module" dates back to some of the oldest code
in the code base. Within the context of Node.js core it usually
refers to modules that are native to Node.js (e.g. fs, http),
but it can cause confusion for people who don't work on this
part of the code base, as "native module" can also refer to
native addons - which is even the case in some of the API
docs and error messages.

This patch tries to make the usage of these terms more consistent.
Now within the context of Node.js core:

- JavaScript scripts that are built-in to Node.js are now referred
  to as "built-in(s)". If they are available as modules,
  they can also be referred to as "built-in module(s)".
- Dynamically-linked shared objects that are loaded into
  the Node.js processes are referred to as "addons".

We will try to avoid using the term "native modules" because it could
be ambiguous.

Changes in this patch:

File names:
- node_native_module.h -> node_builtins.h,
- node_native_module.cc -> node_builtins.cc

C++ binding names:
- `native_module` -> `builtins`

`node::Environment`:
- `native_modules_without_cache` -> `builtins_without_cache`
- `native_modules_with_cache` -> `builtins_with_cache`
- `native_modules_in_snapshot` -> `builtins_in_cache`
- `native_module_require` -> `builtin_module_require`

`node::EnvSerializeInfo`:
- `native_modules` -> `builtins

`node::native_module::NativeModuleLoader`:
- `native_module` namespace -> `builtins` namespace
- `NativeModuleLoader` -> `BuiltinLoader`
- `NativeModuleRecordMap` -> `BuiltinSourceMap`
- `NativeModuleCacheMap` -> `BuiltinCodeCacheMap`
- `ModuleIds` -> `BuiltinIds`
- `ModuleCategories` -> `BuiltinCategories`
- `LoadBuiltinModuleSource` -> `LoadBuiltinSource`

`loader.js`:
- `NativeModule` -> `BuiltinModule` (the `NativeModule` name used in
  `process.moduleLoadList` is kept for compatibility)

And other clarifications in the documentation and comments.

PR-URL: https://github.com/nodejs/node/pull/44135
Fixes: https://github.com/nodejs/node/issues/44036
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Jan Krems <jan.krems@gmail.com>
2022-08-09 01:36:49 +08:00
Livia Medeiros
3ec88760e6
doc: add Retry CI in collaborator guide
PR-URL: https://github.com/nodejs/node/pull/44130
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-08-06 23:38:40 +00:00
Antoine du Hamel
81a68b37cf
doc: improve documentation for safe Promise statics alternatives
PR-URL: https://github.com/nodejs/node/pull/43759
Refs: https://github.com/nodejs/node/pull/43728
Reviewed-By: Feng Yu <F3n67u@outlook.com>
2022-07-25 15:01:22 +01:00
Keyhan Vakil
10ee408e86
doc: recommend git-node-v8
Per the comments in #43924, almost everyone uses `git-node-v8`. I
included example steps for using `git-node-v8`.

I ran through both of these instructions on a clean Linux machine (I had
to fudge the patch SHA of course) and they seemed to work.

Refs: https://github.com/nodejs/node/pull/43924

PR-URL: https://github.com/nodejs/node/pull/43934
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-07-25 12:31:42 +01:00
Keyhan Vakil
a9cb6723b5
doc: remind backporter about v8_embedder_string
There's already a reminder earlier in the instructions, but not in the
worked example, so it's easy to miss while skimming.

PR-URL: https://github.com/nodejs/node/pull/43924
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-24 13:01:14 +01:00
RafaelGSS
9022efb977 doc: mention Win 32-bit openssl build issue
PR-URL: https://github.com/nodejs/node/pull/43853
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-20 09:17:59 -03:00
Beth Griggs
c7843659e2
doc: add security release specifics to releases.md
Co-authored-by: Rafael Gonzaga <rafael.nunu@hotmail.com>

PR-URL: https://github.com/nodejs/node/pull/43835
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-07-20 11:08:53 +01:00
Michael Dawson
4eb8e3fb58
doc: add platform-windows-arm to who to CC
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43808
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Stewart X Addison <sxa@redhat.com>
2022-07-17 09:06:36 +01:00
RafaelGSS
6d7087e40d doc: include make clean to openssl arch
PR-URL: https://github.com/nodejs/node/pull/43735
Fixes: https://github.com/nodejs/node/issues/43667
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-07-15 15:46:27 -03:00
Rafael Gonzaga
52483a0e5d
doc: add link to diagnostic tools
PR-URL: https://github.com/nodejs/node/pull/43736
Fixes: https://github.com/nodejs/diagnostics/issues/567
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-07-15 19:23:27 +01:00
Rafael Gonzaga
2f169ad58a
doc: clarify release process for new releasers
PR-URL: https://github.com/nodejs/node/pull/43739
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
2022-07-13 18:30:19 +01:00
Luigi Pinca
ed7631dae9
doc: remove bullet point referring to Node.js 12
Refs: https://github.com/nodejs/node/pull/43734#pullrequestreview-1033019134

PR-URL: https://github.com/nodejs/node/pull/43744
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
2022-07-12 05:27:22 +01:00
Rafael Gonzaga
e9d7765b46 doc: include last security release date
PR-URL: https://github.com/nodejs/node/pull/43774
Refs: 5a62789b81
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-07-11 16:13:13 -03:00
Rafael Gonzaga
45a4fdbfb4
doc: remove openssl 1.x reference
PR-URL: https://github.com/nodejs/node/pull/43734
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
2022-07-11 09:48:29 +01:00
RafaelGSS
819ff24aa1 doc: remove node-report from support tiers
PR-URL: https://github.com/nodejs/node/pull/43737
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
2022-07-09 17:14:03 -03:00
RafaelGSS
4176671a91 doc: update changelog-maker to the new flags
PR-URL: https://github.com/nodejs/node/pull/43696
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-07 14:08:36 -03:00
Tony Gorez
92cd72626e doc: remove appmetrics from tierlist
PR-URL: https://github.com/nodejs/node/pull/43608
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de>
2022-07-03 20:01:02 +02:00
Tony Gorez
627497bd50 doc: remove systemtap from tierlist
PR-URL: https://github.com/nodejs/node/pull/43605
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard St<C3><B6>bich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-03 19:53:47 +02:00
Michael Dawson
2de8dd15c1
doc: add single executable application initiative
Refs: https://github.com/nodejs/node/issues/43432
Refs: https://github.com/nodejs/node/pull/42334
Refs: https://github.com/nodejs/node/blob/main/doc/contributing/technical-priorities.md#single-executable-applications

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43611
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-03 18:34:05 +01:00
Tony Gorez
dca76e7990 doc: remove windows xperf from tierlist
PR-URL: https://github.com/nodejs/node/pull/43607
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
2022-07-03 19:27:38 +02:00
Tony Gorez
85fb533a24 doc: remove lttng from tierlist
PR-URL: https://github.com/nodejs/node/pull/43604
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-03 19:25:49 +02:00
Tony Gorez
574ad6d89d
doc: remove dtrace from tierlist
PR-URL: https://github.com/nodejs/node/pull/43606
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-01 20:58:09 +01:00
Tony Gorez
952cc0a038
doc: promote 0x to tier 4
PR-URL: https://github.com/nodejs/node/pull/43609
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2022-07-01 20:58:01 +01:00
Rafael Gonzaga
56c15f1c95
doc: include CVSS mention
PR-URL: https://github.com/nodejs/node/pull/43602
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
2022-06-30 18:05:54 +01:00
Livia Medeiros
a0440c9174
doc: add backport-open-vN.x step to backporting guide
PR-URL: https://github.com/nodejs/node/pull/43590
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-29 20:35:41 +01:00
Michael Dawson
23b38e7109 doc: add Juan as a security steward
Ran through onboaring with Juan today. Add him
to the rotation for security stewards.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43512
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-22 15:43:06 -04:00
Feng Yu
8f1d57a005
doc: update v8 doc link to v8.dev
PR-URL: https://github.com/nodejs/node/pull/43482
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Harshitha K P <harshitha014@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-19 08:43:59 +01:00
Richard Lau
5a8440bc51
doc: update main branch name in release guide
PR-URL: https://github.com/nodejs/node/pull/43437
Refs: https://github.com/nodejs/node/issues/33864
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Michael Dawson <midawson@redhat.com>
2022-06-16 23:23:20 +01:00
Michael Dawson
9dc9399416
doc: fixup after rename of primary nodejs branch
Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43453
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
2022-06-16 20:57:30 +01:00
Luigi Pinca
7bf50bc26a
doc: update main branch name in doc/contributing/*
Refs: https://github.com/nodejs/node/issues/33864

PR-URL: https://github.com/nodejs/node/pull/43438
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2022-06-16 14:10:56 +01:00
Antoine du Hamel
358008f473
tools,doc: add guards against prototype pollution when creating proxies
PR-URL: https://github.com/nodejs/node/pull/43391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
2022-06-16 00:26:48 +02:00
Michael Dawson
cc82f6f8a6 doc: add initial doc on how to update cjs-module-lexer
Add some initial doc based on discussion with Guy
Bedford.

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43255
Reviewed-By: Guy Bedford <guybedford@gmail.com>
2022-06-14 09:57:24 -04:00
Michael Dawson
83ffb791f4 doc: clarify use of deps/icu-small
Add some additional info about use of icu
subset in deps/icu-small

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: https://github.com/nodejs/node/pull/43287
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2022-06-14 09:54:43 -04:00
Tony Gorez
4f3b8fa842
doc: remove llnode from diag tierlist
PR-URL: https://github.com/nodejs/node/pull/43289
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-13 17:09:57 +01:00
Tony Gorez
3786ef63b0
doc: remove ETW from diag tierlist
PR-URL: https://github.com/nodejs/node/pull/43295
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-06-13 17:09:44 +01:00
Feng Yu
3296d6d23d
doc: change glossary link in pull request guide to node's glossary doc
PR-URL: https://github.com/nodejs/node/pull/43318
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-08 19:42:53 +01:00
Kohei Ueno
18a0eadeaa
doc: make clear the result of comparison between Symbol.for
PR-URL: https://github.com/nodejs/node/pull/43309
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-06 14:28:48 +01:00
Feng Yu
93d10d62d9
doc: use serial comma in pull request doc
PR-URL: https://github.com/nodejs/node/pull/43319
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-06-05 18:48:08 +01:00
Tony Gorez
ac27c58180
doc: promote cdt to tier 3
PR-URL: https://github.com/nodejs/node/pull/43290
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
2022-06-03 14:59:35 +01:00
rikapo
218664f638
doc: fix chromium document link in pull-requests.md
PR-URL: https://github.com/nodejs/node/pull/43265
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-06-03 00:27:08 +01:00
Tobias Nießen
0ef81d120d
doc: add src/crypto to CC list for nodejs/crypto
PR-URL: https://github.com/nodejs/node/pull/43286
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-01 20:49:45 +01:00
Antoine du Hamel
df5664440e
doc: add note regarding %Array.prototype.concat% in primordials.md
PR-URL: https://github.com/nodejs/node/pull/43166
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
2022-05-29 08:43:52 +01:00
Livia Medeiros
38a39143d2
doc: make minor adjustments
PR-URL: https://github.com/nodejs/node/pull/43175
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
2022-05-24 10:27:17 +01:00
Feng Yu
b4398df2e5
tools: refactor build-addons.js to ESM
PR-URL: https://github.com/nodejs/node/pull/43099
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-22 14:28:41 +01:00
mawaregetsuka
40162dbe36
doc: improved parallel specification
PR-URL: https://github.com/nodejs/node/pull/42679
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-22 12:47:38 +01:00
DeeDeeG
5d9ad80478
doc: remove outdated footnote (Python 2 --> 3 for V8 tests)
Various Python 3 compatibility fixes were made in upstream V8,
and they have even dropped Python 2 compatibility in various scripts.

depot_tools, which bootstraps the V8 build, is also moving to Python 3.

As of Node v18.0.0-ish, this footnote is no-longer accurate.

(Running `make test-v8` no-longer requires Python 2,
and it won't work anymore if you don't have a copy of Python 3.)

PR-URL: https://github.com/nodejs/node/pull/43105
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
2022-05-22 11:41:46 +01:00
Tobias Nießen
895cc572ac
doc: use ASCII apostrophes consistently
PR-URL: https://github.com/nodejs/node/pull/43114
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-05-17 20:04:51 +01:00