Commit Graph

2 Commits

Author SHA1 Message Date
Rich Trott
87ea0caa9f test: improve test-gc-http-client
Calling `global.gc()` in multiple places leads to unreliability. Call it
in the interval only.

PR-URL: https://github.com/nodejs/node/pull/23145
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-10-01 21:48:00 -07:00
Rich Trott
7d03ff188a test: improve reliability of test-gc-http-client
test-gc-http-client is resource-intensive. It times out a lot on CI.
Move to sequential.

Approved for fast-tracking by:
Anna Henningsen <anna@addaleax.net>
Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/23087
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-09-26 07:30:06 +02:00