jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-06 20:08:02 +00:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity
29,241 Commits 67 Branches 878 Tags 2.1 GiB
b0f67f2fc7
Commit Graph

8 Commits

Author SHA1 Message Date
Andrew Hughes
b0f67f2fc7 test: prefer server over srv 
PR-URL: https://github.com/nodejs/node/pull/31224
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
 2020-01-08 21:36:11 -08:00
Ouyang Yadong
3458e65127 net: net.Server.listen() avoid operations on null when fail 
When `net.Server` fails to create a new handle, an error shall be
emitted in the next tick. Therefore, we make `net.Server.listen()`
directly  return to avoid following operations on `null`
`this._handle`.

Fixes: https://github.com/nodejs/node/issues/23917

PR-URL: https://github.com/nodejs/node/pull/23920
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
 2018-11-05 21:02:56 -08:00
Timothy Gu
fdbc668ea3 test: fix incorrect file mode check 
PR-URL: https://github.com/nodejs/node/pull/22023
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2018-08-03 08:26:05 -07:00
Bartosz Sosnowski
531b4bedca net: allow IPC servers be accessible by all 
Adds mappings to uv_pipe_chmod call by adding two new options to
listen call. This allows the IPC server pipe to be made readable or
writable by all users.

Fixes: https://github.com/nodejs/node/issues/19154

PR-URL: https://github.com/nodejs/node/pull/19472
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
 2018-05-24 11:06:12 +02:00
Rich Trott
bf6ce47259 test: move tmpdir to submodule of common 
Move tmpdir functionality to its own module (common/tmpdir).

PR-URL: https://github.com/nodejs/node/pull/17856
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2018-01-31 22:11:07 -08:00
Sebastiaan Deckers
bb29405904
lib,src: fix consistent spacing inside braces 
PR-URL: https://github.com/nodejs/node/pull/14162
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2017-07-21 15:13:47 -04:00
Vse Mozhet Byt
8b76c3e60c test: reduce string concatenations 
PR-URL: https://github.com/nodejs/node/pull/12735
Refs: https://github.com/nodejs/node/pull/12455
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2017-05-05 17:39:05 +03:00
Joyee Cheung
474e9d64b5 test: add more test cases of server.listen option 
* Test listening with different handle and fd
* Test listening without callback

PR-URL: https://github.com/nodejs/node/pull/11778/
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
 2017-03-16 13:17:32 +08:00