2 Commits

Author	SHA1	Message	Date
Joyee Cheung	65d396b0a0	test: use spawnSyncAndExitWithoutError in sea tests ... To display more information when the command fails. PR-URL: https://github.com/nodejs/node/pull/49543 Refs: https://github.com/nodejs/reliability/issues/658 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>	2023-09-11 16:39:37 +00:00
Joyee Cheung	5c9daf4583	sea: generate code cache with deserialized isolate ... V8 now requires code cache to be compiled from an isolate with the same RO space layout as the one that's going to deserialize the cache, so for a binary built with snapshot, we need to compile the code cache using a deserialized isolate. Drive-by: ignore "useCodeCache" when "useSnapshot" is true because the compilation would've been done during build time anyway in that case, and print a warning for it. PR-URL: https://github.com/nodejs/node/pull/49226 Refs: https://github.com/nodejs/node-v8/issues/252 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>	2023-08-22 16:56:04 +00:00