2 Commits

Author	SHA1	Message	Date
Keyhan Vakil	7a4e7532aa	test: deflake test-diagnostics-channel-net ... This test uses the deprecated methods in `diagnostic_channel` (see the reference), which are deprecated because the channels can be GC'd while in use, leading to lost messages. Change to use the non-deprecated APIs, which should work. I wasn't able to reproduce this locally; I assume it's memory dependent. Refs: https://github.com/nodejs/node/pull/42714 Fixes: https://github.com/nodejs/node/issues/44143 PR-URL: https://github.com/nodejs/node/pull/44144 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>	2022-08-07 06:57:29 +00:00
theanarkh	60898eed65	lib: add diagnostics channel and perf hooks detail ... PR-URL: https://github.com/nodejs/node/pull/43984 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2022-07-29 14:27:16 +01:00