Commit Graph

6 Commits

Author SHA1 Message Date
Deokjin Kim
d8014f6aa9 test: use os.availableParallelism()
Refs: https://github.com/nodejs/node/pull/45895
PR-URL: https://github.com/nodejs/node/pull/46003
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
2023-01-11 20:07:56 +00:00
Nick Sia
a31d572f00
test: deflake gc-http-client tests by restricting number of requests
sequential/test-gc-http-client tests were sometimes failing due to
a non-deterministic number of requests being created, causing the
test to fail on some systems with a "ECONNRESET" error caused by
too many concurrent connections

Fixes: https://github.com/nodejs/node/issues/43638
PR-URL: https://github.com/nodejs/node/pull/44146
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: theanarkh <theratliter@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2022-08-07 12:44:25 +00:00
Luigi Pinca
d01c645b9b
test: move test-gc-http-client-onerror to sequential
Fixes: https://github.com/nodejs/node/issues/41399

PR-URL: https://github.com/nodejs/node/pull/41619
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
2022-01-22 19:32:40 +00:00
Anna Henningsen
627bcf7f27
test: move some gc tests back to parallel/, unmark flaky
These should no longer be flaky after the libuv update.

Refs: https://github.com/nodejs/node/pull/23336

PR-URL: https://github.com/nodejs/node/pull/23356
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-10-12 14:27:53 -07:00
Denys Otrishko
0ea804aae5
test: improve test-gc-http-client-onerror
* refactor out usage of 'function' for scoping
* inline runTest function

PR-URL: https://github.com/nodejs/node/pull/23196
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-10-12 14:24:39 -07:00
Rich Trott
0ae146cd8e test: improve test-gc-http-client-onerror
test-gc-http-client-onerror is resource-intensive. It times out a lot on
CI. Move to sequential.

Approved for fast-tracking by:
Anna Henningsen <anna@addaleax.net>
Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/23090
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2018-09-26 07:43:47 +02:00