3 Commits

Author	SHA1	Message	Date
ZYSzys	dcc5e51e1c	tools: force common be required before any other modules ... PR-URL: https://github.com/nodejs/node/pull/27650 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>	2019-05-13 19:39:34 +08:00
Joyee Cheung	f131ea6faf	test: make sure tmpdir is created before using it ... Otherwise it throws ENOENT when the folder happens to be cleaned PR-URL: https://github.com/nodejs/node/pull/25224 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2019-01-02 15:00:21 +01:00
Eduard Bondarenko	20770073ba	child_process: spawn ignores options in case args is undefined ... spawn method ignores 3-d argument 'options' in case the second one 'args' equals to 'undefined'. Fixes: https://github.com/nodejs/node/issues/24912 PR-URL: https://github.com/nodejs/node/pull/24913 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>	2018-12-16 07:22:45 -08:00