Commit Graph

7 Commits

Author SHA1 Message Date
Anna Henningsen
702e11454e
Revert "test: mark async-hooks/test-callback-error as flaky"
This reverts commit 59c8abf886.

PR-URL: https://github.com/nodejs/node/pull/22655
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: George Adams <george.adams@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
2018-09-05 12:39:43 +02:00
Joyee Cheung
59c8abf886
test: mark async-hooks/test-callback-error as flaky
Refs: https://github.com/nodejs/node/issues/15985

PR-URL: https://github.com/nodejs/node/pull/22330
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2018-08-15 22:47:51 +08:00
Joyee Cheung
b87cb5da44
test: mark async-hooks/test-statwatcher as flaky
Refs: https://github.com/nodejs/node/issues/21425

PR-URL: https://github.com/nodejs/node/pull/22330
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
2018-08-15 22:47:50 +08:00
Anatoli Papirovski
d52878137d test: unmark test-zlib.zlib-binding.deflate flaky
PR-URL: https://github.com/nodejs/node/pull/21109
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
2018-06-03 15:33:29 +02:00
Matheus Marchini
f96ef5574c
test: mark test-zlib.zlib-binding.deflate as flaky
test-zlib.zlib-binding.deflate is failing continuously in our CI,
leaving us with 1% successful builds during the last 100 runs. This
commit marks the test as flaky while the issue is not resolved.

Ref: https://github.com/nodejs/node/issues/20907

PR-URL: https://github.com/nodejs/node/pull/20935
Refs: https://github.com/nodejs/node/issues/20907
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2018-05-24 11:59:59 -03:00
Anna Henningsen
4dff05f4a7 src: fix process.abort() interaction with V8
Since V8 5.9 V8 installs a default signal handler for some signals
when creating a default platform instance that prints a stack trace.

However, Node already does the same thing, so it would seem like the
two different stack traces would be printed; also, the V8 handler
would lead to a `SIGSEGV` under some circumstances, rather than
letting the abort continue normally.

Resolve this by disabling V8’s signal handler by default.

PR-URL: https://github.com/nodejs/node/pull/13985
Fixes: https://github.com/nodejs/node/issues/13865
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2017-07-02 15:42:22 -07:00
Refael Ackermann
32c7f114c5 test: improve async-hooks/test-callback-error
PR-URL: https://github.com/nodejs/node/pull/13559
Fixes: https://github.com/nodejs/node/issues/13527
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
2017-06-21 06:13:04 -04:00