jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-05 20:40:15 +00:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity
15,596 Commits 67 Branches 878 Tags 2.1 GiB
6ed0e8b49c
Commit Graph

2 Commits

Author SHA1 Message Date
Michaël Zasso
29da8cf8d7 util: make inherits work with classes 
The current implementation overwrites the prototype of the target
constructor. It is not allowed with ES2015 classes because the prototype
property is read only. Use Object.setPrototypeOf instead.

Fixes: https://github.com/nodejs/node/issues/3452
PR-URL: https://github.com/nodejs/node/pull/3455
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2015-10-27 06:40:05 +01:00
Michaël Zasso
df738ac56c test: improve tests for util.inherits 
inherits is used in lib and tests but its functionality itself is not
tested yet.

PR-URL: https://github.com/nodejs/node/pull/3507
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
 2015-10-26 09:37:33 +01:00