Commit Graph

3 Commits

Author SHA1 Message Date
Livia Medeiros
57678e5581
fs: add read(buffer[, options]) versions
This adds the following:
- `fs.read(fd, buffer[, options], callback)`.
- `filehandle.read(buffer[, options])`.

PR-URL: https://github.com/nodejs/node/pull/42768
Refs: https://github.com/nodejs/node/pull/42601
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-05-02 20:01:27 +02:00
Rich Trott
a9f5b2b62c test: update comments in test-fs-read-offset-null
Update comment to refer to the correct ASCII code (120 rather than 66).
All other changes are cosmetic.

PR-URL: https://github.com/nodejs/node/pull/36152
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
2020-11-21 04:32:13 -08:00
mayank agarwal
0027aca332 test: add test for fs.read when offset key is null
added test for uncovered if statement in lib/fs.js

PR-URL: https://github.com/nodejs/node/pull/35918
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
2020-11-17 08:26:07 -08:00