3 Commits

Author	SHA1	Message	Date
Benjamin Zaslavsky	30892c8fb4	test: fix require-deps-deprecation for installed deps ... Test test-require-deps-deprecation.js was failing when user already had node installed with acorn in require.resolve range. Modified test to acknowledge the possibility and throw only if acorn is found in the deps directory. PR-URL: https://github.com/nodejs/node/pull/17848 Fixes: https://github.com/nodejs/node/issues/17148 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2018-01-03 13:59:52 -05:00
Timothy Gu	7ce6d23387	test: add test for importing acorn ... PR-URL: https://github.com/nodejs/node/pull/15566 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	2017-11-16 15:42:00 -08:00
Timothy Gu	0e10717e43	build: runtime-deprecate requiring deps ... PR-URL: https://github.com/nodejs/node/pull/16392 Fixes: https://github.com/nodejs/node/pull/15566#discussion_r146111170 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>	2017-11-13 10:50:12 -08:00