Commit Graph

8 Commits

Author SHA1 Message Date
Rich Trott
f72c1978e0
tools: consolidate update-authors.js logic
Use a single regex and fewer logical branches in the code.

PR-URL: https://github.com/nodejs/node/pull/41255
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
2021-12-23 06:46:26 +00:00
Rich Trott
1a6d92728f tools,meta: remove exclusions from AUTHORS
The update-authors tool omits Chromium team members. This was a decision
made years ago. The idea was that these folks contributed to V8 not to
Node.js, as they typically ended up in our code-base via cherry-picked
commits from V8.
Ref: https://github.com/nodejs/node/pull/232#discussion-diff-22412788

Now that there are over 3000 contributors identified in AUTHORS, some of
whom are bots that we run, I think it's time to undo this exception. If
we used someone else's code in a cherry-pick, congratulations to them,
they're authors. In particular, this will fix the omission of Yang
Guo who contributed extensively to Node.js outside of V8 contributions.

PR-URL: https://github.com/nodejs/node/pull/40648
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
2021-10-31 15:23:21 +00:00
Rich Trott
d4842e64bb tools: fix formatting of warning message in update-authors.js
The email already has `<` and `>` surrounding it so adding it results in
a misformatted message.

PR-URL: https://github.com/nodejs/node/pull/40600
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2021-10-26 10:07:14 +00:00
Rich Trott
d6d6b050ff tools: warn about duplicates when generating AUTHORS file
PR-URL: https://github.com/nodejs/node/pull/40304
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
2021-10-09 08:05:11 -07:00
Rich Trott
978343f574 tools: email matchin is case insensitive for .mailmap
PR-URL: https://github.com/nodejs/node/pull/39430
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2021-07-20 21:39:08 -07:00
Anna Henningsen
f9d026dbb7 tools: make mailmap processing for author list case-insensitive
This is to accommodate Myles Borins otherwise ending up with
multiple entries due to different casing in the email 🙂

PR-URL: https://github.com/nodejs/node/pull/29608
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
2019-09-24 21:50:59 -07:00
Anna Henningsen
713046d9eb
tools: add mailmap support for Co-authored-by tags
Support `.mailmap` for manually added `Author:` and
`Co-authored-by:` tags.

PR-URL: https://github.com/nodejs/node/pull/26383
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
2019-03-06 00:04:55 +01:00
Anna Henningsen
175a88f094
tools: implement update-authors in JS
Replace the previous Perl script with a Node.js variant
that explicitly supports `Author:` and, in particular,
GitHub’s standard `Co-authored-by:` metadata tags.

PR-URL: https://github.com/nodejs/node/pull/22771
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2018-09-14 18:58:25 +02:00