Commit Graph

4 Commits

Author SHA1 Message Date
Rich Trott
0e1fd8d0b4 test: allow ENOENT in test-worker-init-failure
PR-URL: https://github.com/nodejs/node/pull/34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
2020-08-16 07:38:14 -07:00
Rich Trott
97d9b9c90e test: allow ENFILE in test-worker-init-failure
Refs: https://github.com/nodejs/node/pull/34727#issuecomment-672862034

PR-URL: https://github.com/nodejs/node/pull/34769
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
2020-08-16 07:38:02 -07:00
Rich Trott
9861962a5f test: remove error message checking in test-worker-init-failure
Let the check for the error code suffice and don't check for a
particular string in the message.

PR-URL: https://github.com/nodejs/node/pull/34727
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
2020-08-13 19:28:46 -07:00
Harshitha KP
5b899d69f1
test: add Worker initialization failure test case
Cover the scenario fixed through
https://github.com/nodejs/node/pull/31621
Unfortunately there is no easy way to test this, in a
cross-platform manner. So the approach is:
 - open a child process with ulimit restriction on file descriptors
 - in the child process, start few workers - more than the fd limit
 - make sure some workers fail, with the expected error type.
 - skip the test in windows, as there is no ulimit there.

Refs: https://github.com/nodejs/node/pull/31621

PR-URL: https://github.com/nodejs/node/pull/31929
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
2020-04-06 01:52:14 +02:00