jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-07 00:42:10 +00:00
Code Issues Actions 14 Packages Projects Releases Wiki Activity
33,668 Commits 67 Branches 878 Tags 2.1 GiB
2ff93c8975
Commit Graph

5 Commits

Author SHA1 Message Date
Ruben Bridgewater
b08a867d60
benchmark,doc,lib: capitalize more comments 
PR-URL: https://github.com/nodejs/node/pull/26849
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
 2019-03-27 17:20:06 +01:00
Ruben Bridgewater
f8763bb077
benchmark,doc,lib,test: capitalize comments 
PR-URL: https://github.com/nodejs/node/pull/26483
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2019-03-10 00:44:40 +01:00
Matteo Collina
f6721c20df stream: writable.end should return this. 
PR-URL: https://github.com/nodejs/node/pull/18780
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2018-02-19 08:59:12 +01:00
Daniel Bevenius
690bdede13 test: fix lint error regarding unused commons const 
Currently, make lint is failing with the following error:
3:7  error  'common' is assigned a value but never used  no-unused-vars
✖ 1 problem (1 error, 0 warnings)

PR-URL: https://github.com/nodejs/node/pull/9334
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
 2016-10-28 12:55:21 +02:00
Italo A. Casas
fd16eed8ea test: writable stream ending state 
Add a test for _writableState.ending, when ending becomes true,
but the stream is not finished/ended yet.

PR-URL: https://github.com/nodejs/node/pull/8707
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Related: https://github.com/nodejs/node/issues/8686
 2016-10-28 08:50:45 +02:00