44 Commits

Author	SHA1	Message	Date
Debadree Chatterjee	1f75a9513f	stream: fix respondWithNewView() errors when view.byteOffset != 0 ... Fixes: https://github.com/nodejs/node/issues/42851 Refs: f894acdd41/reference-implementation/lib/abstract-ops/readable-streams.js (L1756) PR-URL: https://github.com/nodejs/node/pull/46465 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2023-02-24 12:54:11 +00:00
Antoine du Hamel	d42628d05a	stream: add trailing commas in webstream source files ... PR-URL: https://github.com/nodejs/node/pull/46685 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Darshan Sen <raisinten@gmail.com>	2023-02-18 18:55:52 +01:00
Debadree Chatterjee	96c720e98f	stream: add abort signal for ReadableStream and WritableStream ... Refs: https://github.com/nodejs/node/issues/39316 PR-URL: https://github.com/nodejs/node/pull/46273 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2023-02-17 11:09:08 +00:00
Antoine du Hamel	fe514bf960	lib: enforce use of trailing commas for functions ... PR-URL: https://github.com/nodejs/node/pull/46629 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>	2023-02-14 18:45:16 +01:00
Antoine du Hamel	da89ab8545	stream: refactor to use validateAbortSignal ... PR-URL: https://github.com/nodejs/node/pull/46520 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2023-02-08 13:28:59 +00:00
MrBBot	03854f6487	stream: allow transfer of readable byte streams ... Updates the `ReadableStream` constructor to mark byte streams as transferable. When transferred, byte streams become regular streams. Refs: https://github.com/nodejs/node/pull/39062 Refs: https://streams.spec.whatwg.org/#rs-transfer PR-URL: https://github.com/nodejs/node/pull/45955 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2023-02-04 19:30:15 +00:00
Deokjin Kim	05296d9246	doc: mark some parameters as optional in webstreams ... Some parameters are described as optional in spec, so update mismatched parameter. Refs: https://streams.spec.whatwg.org/ PR-URL: https://github.com/nodejs/node/pull/46269 Refs: https://streams.spec.whatwg.org/ Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2023-01-21 12:03:10 +01:00
Debadree Chatterjee	32254988ba	stream: implement finished() for ReadableStream and WritableStream ... Refs: https://github.com/nodejs/node/issues/39316 PR-URL: https://github.com/nodejs/node/pull/46205 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2023-01-18 07:56:49 +00:00
Deokjin Kim	44595b48f0	lib: use kEmptyObject and update JSDoc in webstreams ... Use kEmptyObject as default value of strategy. Plus, make reason and chunk as optional. And refactor to use validateBuffer. Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollerenqueuechunk Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#transformstreamdefaultcontrollererrorreason Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterabortreason Refs: https://github.com/nodejs/node/blob/main/doc/api/webstreams.md#writablestreamdefaultwriterwritechunk PR-URL: https://github.com/nodejs/node/pull/46183 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2023-01-15 22:10:42 +00:00
Rafael Gonzaga	5d50b8435c	lib: reuse invalid state errors on webstreams ... Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/46086 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2023-01-13 03:33:29 +00:00
Yagiz Nizipli	dda7a21b07	stream: use structuredClone instead of v8 ... PR-URL: https://github.com/nodejs/node/pull/45611 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2022-11-27 04:47:41 +00:00
Yagiz Nizipli	9a8d82b99f	src: add internal isArrayBufferDetached ... PR-URL: https://github.com/nodejs/node/pull/45568 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: LiviaMedeiros <livia@cirno.name>	2022-11-27 03:14:57 +00:00
Yagiz Nizipli	4bcc3aab76	stream: use ArrayBufferPrototypeGetByteLength ... PR-URL: https://github.com/nodejs/node/pull/45528 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2022-11-21 22:45:16 +00:00
Jithil P Ponnan	e9ba08e116	stream: fix web streams have no Symbol.toStringTag ... stream: fix web streams have no Symbol.toStringTag stream: add unit tests PR-URL: https://github.com/nodejs/node/pull/45117 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>	2022-10-26 15:48:48 +00:00
Antoine du Hamel	eb32a8443a	lib: add lint rule to protect against Object.prototype.then pollution ... PR-URL: https://github.com/nodejs/node/pull/45061 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>	2022-10-21 03:12:03 +00:00
Daeyeon Jeong	43e2f60be0	stream: handle enqueuing chunks when a pending BYOB pull request exists ... Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2022-10-02 10:14:57 +00:00
Daeyeon Jeong	e213deabe5	stream: handle a pending pull request from a released reader ... In order to meet the specification, this includes mainly the followings: - Adding the 'release steps' to ReadableStreamController - Responding to a pull request from a released reader in ReadableByteStreamController Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44702 Refs: https://streams.spec.whatwg.org/#abstract-opdef-readablebytestreamcontroller-releasesteps Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-in-readable-state Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2022-09-23 12:01:52 +00:00
Daeyeon Jeong	e06384cb48	stream: add ReadableByteStream.tee() ... This supports teeing readable byte streams to meet the latest web streams standards. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44505 Refs: https://streams.spec.whatwg.org/#readable-stream-tee Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-09-08 22:06:06 +00:00
Daeyeon Jeong	aa90e7a9f4	stream: fix setting abort reason in ReadableStream.pipeTo() ... In 14.2 in the specification, `error` should be signal’s abort reason. The current behavior seems to assume that only an `AbortError` instance is given as signal’s abort reason. Refs: https://streams.spec.whatwg.org/#readable-stream-pipe-to Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44418 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>	2022-09-03 14:24:29 +00:00
Daeyeon Jeong	cc75a3c11e	stream: fix ReadableStreamReader.releaseLock() ... Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44292 Refs: https://streams.spec.whatwg.org/#default-reader-release-lock Refs: https://streams.spec.whatwg.org/#byob-reader-release-lock Refs: https://developer.mozilla.org/en-US/docs/Web/API/ReadableStreamDefaultReader/releaseLock Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2022-08-27 11:27:10 +00:00
Antoine du Hamel	ce639629dd	lib: use safe Promise alternatives when available ... PR-URL: https://github.com/nodejs/node/pull/43476 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>	2022-08-27 11:37:01 +02:00
Daeyeon Jeong	937520a764	stream: fix isDetachedBuffer validations ... Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44114 Refs: https://github.com/nodejs/node/pull/43866 Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-08-18 08:24:34 +00:00
Daeyeon Jeong	46f6d225af	stream: improve views validation on BYOBRequest ... - This throws if the view is zero-length when there is an active reader when using `ReadableStreamBYOBRequest.respondWithNewView()`. - By doing that, we can get all tests passed in `readable-byte-streams/bad-buffers-and-views.any.js`. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/44155 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-respond-with-new-view Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2022-08-15 18:46:13 +00:00
Antoine du Hamel	d7f193434a	lib: add Promise methods to avoid-prototype-pollution lint rule ... PR-URL: https://github.com/nodejs/node/pull/43849 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Paolo Insogna <paolo@cowtech.it>	2022-07-26 23:38:24 +01:00
Daeyeon Jeong	0c27ca4bc9	stream: improve respondWithNewView() ... This fixes validating an ArrayBufferView given to ReadableStreamBYOBRequest.respondWithNewView() to improve the web streams compatibility. Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com PR-URL: https://github.com/nodejs/node/pull/43866 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>	2022-07-24 17:56:48 +01:00
Antoine du Hamel	bb30e2da7a	lib: use null-prototype objects for property descriptors ... PR-URL: https://github.com/nodejs/node/pull/43473 Reviewed-By: Darshan Sen <raisinten@gmail.com>	2022-06-27 16:29:10 +01:00
LiviaMedeiros	a0178a1169	stream: use kEmptyObject ... PR-URL: https://github.com/nodejs/node/pull/43159 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-06-11 12:18:14 +02:00
Antoine du Hamel	06d8606960	lib: use null-prototype objects for property descriptors ... Refs: https://github.com/nodejs/node/pull/42921 PR-URL: https://github.com/nodejs/node/pull/43270 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2022-06-03 09:23:58 +01:00
Gang Chen	de77515a77	lib: clean after the cancel algorithm throw error ... PR-URL: https://github.com/nodejs/node/pull/41366 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>	2022-02-26 13:19:42 +00:00
Sean Quinlan	26f9a91cc9	lib: allow respondWithNewView on byob auto allocated streams ... Fixes: https://github.com/nodejs/node/issues/41886 PR-URL: https://github.com/nodejs/node/pull/41887 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>	2022-02-16 22:28:56 +00:00
Mestery	998e5acc69	lib: move kEnumerableProperty to internal/util ... PR-URL: https://github.com/nodejs/node/pull/41877 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-02-11 17:30:47 +00:00
Rich Trott	73a75c2ee6	stream: remove empty block ... PR-URL: https://github.com/nodejs/node/pull/41831 Refs: https://eslint.org/docs/rules/no-empty Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-02-05 12:58:31 +00:00
voltrexmaster	c4a6f9ab94	stream: rename unknown primordial ... The primordials does not expose a primordial called `DataViewCtor`, leading up to a non-existent constructor. Fixes: https://github.com/nodejs/node/issues/40612 PR-URL: https://github.com/nodejs/node/pull/40622 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>	2022-01-20 09:19:37 +00:00
Rich Trott	b161440cd3	stream: remove unused function argument ... watchClosed() is only ever called with an anonymous function for the action parameter. This anonymous funciton does not take any arguments. Remove unused argument from invocation of action(). PR-URL: https://github.com/nodejs/node/pull/41403 Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2022-01-07 16:49:16 +00:00
Robert Nagy	a698c49993	stream: add isReadable helper ... PR-URL: https://github.com/nodejs/node/pull/41199 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>	2021-12-29 20:42:10 +01:00
Rafael Gonzaga	113133badb	stream: fix enqueue race condition on esm modules ... stream: use nextTick on close PR-URL: https://github.com/nodejs/node/pull/40901 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2021-12-21 10:24:15 +00:00
Rich Trott	29f714b152	lib,tools: remove empty lines between JSDoc tags ... This is in preparation for enabling a recommended JSDoc lint rule. PR-URL: https://github.com/nodejs/node/pull/41147 Reviewed-By: Luigi Pinca <luigipinca@gmail.com>	2021-12-19 05:30:09 +00:00
Robert Nagy	752d75d8bc	stream: add isErrored helper ... Refs: https://github.com/nodejs/undici/pull/1134 PR-URL: https://github.com/nodejs/node/pull/41121 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>	2021-12-16 14:28:31 +01:00
James M Snell	bc2944ae27	stream: fix the ReadableStreamBYOBReader error message ... PR-URL: https://github.com/nodejs/node/pull/40846 Reviewed-By: Robert Nagy <ronagy@icloud.com>	2021-11-25 08:36:01 -08:00
Robert Nagy	4832d1c02c	stream: add isDisturbed helper ... Adds a helper util used to determine whether a stream has been disturbed (read or cancelled). Refs: https://github.com/nodejs/node/issues/39627 PR-URL: https://github.com/nodejs/node/pull/39628 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2021-08-06 07:45:38 +02:00
James M Snell	6ad3872d5e	stream: import internal/util/types instead ... Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39331 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>	2021-07-15 13:43:26 -07:00
James M Snell	2cc13ad6a8	stream: fixup property definition to avoid prototype polution ... Fixup the definitions of the properties to avoid the possibility of prototype polution on the object definitions. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39371 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>	2021-07-13 10:50:02 -07:00
Tobias Nießen	528639c5fe	lib: rename TransferedReadableStream etc ... PR-URL: https://github.com/nodejs/node/pull/39352 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>	2021-07-13 08:09:31 +02:00
James M Snell	fa0c6883a6	stream: implement WHATWG streams ... Experimental implementation of the WHATWG streams standard. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: https://github.com/nodejs/node/pull/39062 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>	2021-06-30 12:54:41 -07:00