Commit Graph

2 Commits

Author SHA1 Message Date
Masashi Hirano
03fb789fb9
events: add null check for the signal of EventTarget
This will improve the Web compatibility.
Passing null as the signal should throw an error.
WPT says "Passing null as the signal should throw".
Please see https://github.com/web-platform-tests/wpt/blob/master/dom/events/AddEventListenerOptions-signal.any.js

PR-URL: https://github.com/nodejs/node/pull/43153
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
2022-10-13 09:58:40 +00:00
Daeyeon Jeong
f209aee3ea
test: rename test-eventtarget-whatwg-*.js
This renames some test filenames to align with the existing
`parallel/test-whatwg-*.js` for consistency.

According to the comment in each file, they are seemingly manually
ported from the `wpt@dom/events` tests.

Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com

PR-URL: https://github.com/nodejs/node/pull/43467
Refs: https://github.com/nodejs/node/pull/43461
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
2022-06-19 00:19:48 +02:00