jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-08 03:13:13 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity
16,098 Commits 67 Branches 878 Tags 2.1 GiB
03d440e3ce
Commit Graph

3 Commits

Author SHA1 Message Date
Rich Trott
d4061a6314 tools: replace custom ESLint rule with built-in 
ESLint 3.5.0 introduces a `no-restricted-properties` rule. Replace our
custom `no-deepEqual` rule with this rule.

PR-URL: https://github.com/nodejs/node/pull/8478
Reviewed-By: James M Snell <jasnell@gmail.com>
 2016-09-12 21:12:03 -07:00
Rich Trott
a7335bd1f0 test,benchmark: use deepStrictEqual() 
In preparation for a lint rule that will enforce
assert.deepStrictEqual() over assert.deepEqual(), change tests and
benchmarks accordingly. For tests and benchmarks that are testing or
benchmarking assert.deepEqual() itself, apply a comment to ignore the
upcoming rule.

PR-URL: https://github.com/nodejs/node/pull/6213
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2016-04-22 14:38:09 -07:00
Claudio Rodriguez
63786227cc assert: typed array deepequal performance fix 
assert.deepEqual: when actual and expected are typed arrays,
wrap them in a new Buffer each to increase performance
significantly.

PR-URL: https://github.com/nodejs/node/pull/4330
Fixes: https://github.com/nodejs/node/issues/4294
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
 2015-12-21 18:04:01 +01:00