jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-04-30 07:19:19 +00:00
Code Issues Actions 19 Packages Projects Releases Wiki Activity
44,020 Commits 56 Branches 878 Tags 2 GiB
main
Commit Graph

3 Commits

Author SHA1 Message Date
Rich Trott
8e189794df test: remove skip of OS X bug 
Three tests are skipped because of Applie bug 17894467. That bug exists
in OS X 10.10, but we no longer support 10.10 (and neither does Apple).
Remove the test-skipping.

PR-URL: https://github.com/nodejs/node/pull/22546
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
 2018-08-30 22:56:01 -07:00
Vse Mozhet Byt
2d2986ae72 test: simplify test skipping 
* Make common.skip() exit.

  Also add common.printSkipMessage() for partial skips.

* Don't make needless things before skip

PR-URL: https://github.com/nodejs/node/pull/14021
Fixes: https://github.com/nodejs/node/issues/14016
Reviewed-By: Refael Ackermann <refack@gmail.com>
 2017-07-04 12:41:49 +03:00
Rich Trott
9b0f53d45a test: fix flaky test-dgram-empty-packet & friends 
* Liberal use of common.mustCall()
* Rename test-dgram-empty-packet -> test-dgram-send-empty-packet
* Remove use of timers to avoid CI failures like seen in the Ref below:

```
not ok 237 parallel/test-dgram-empty-packet
  ---
  duration_ms: 0.717
  severity: fail
  stack: |-
        ...
        throw new Error('Timeout');
        ^

    Error: Timeout
        at Timeout._onTimeout
        ...
        at ontimeout (timers.js:365:14)
        at tryOnTimeout (timers.js:237:5)
        at Timer.listOnTimeout (timers.js:207:5)
```

Refs: https://ci.nodejs.org/job/node-test-commit-freebsd/5341/nodes=freebsd11-x64/console:
PR-URL: https://github.com/nodejs/node/pull/9724
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
 2016-11-24 14:37:41 -08:00