jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-21 19:44:16 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

worker: mention argument name in type check message

Browse Source 
Refs: https://github.com/nodejs/node/pull/32745#discussion_r406564208

PR-URL: https://github.com/nodejs/node/pull/32815
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
This commit is contained in:
Anna Henningsen 2020-04-13 15:08:54 +02:00
parent 953445873a
commit d699fdd2c6
No known key found for this signature in database
GPG Key ID: A94130F0BFC8EBE9
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/node_messaging.cc
View File

@ -869,7 +869,7 @@ void MessagePort::ReceiveMessage(const FunctionCallbackInfo<Value>& args) {
if (!args[0]->IsObject() || if (!args[0]->IsObject() ||
!env->message_port_constructor_template()->HasInstance(args[0])) { !env->message_port_constructor_template()->HasInstance(args[0])) {
return THROW_ERR_INVALID_ARG_TYPE(env, return THROW_ERR_INVALID_ARG_TYPE(env,
"First argument needs to be a MessagePort instance"); "The \"port\" argument must be a MessagePort instance");
} }
MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>()); MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>());
if (port == nullptr) { if (port == nullptr) {
@ -890,7 +890,7 @@ void MessagePort::MoveToContext(const FunctionCallbackInfo<Value>& args) {
if (!args[0]->IsObject() || if (!args[0]->IsObject() ||
!env->message_port_constructor_template()->HasInstance(args[0])) { !env->message_port_constructor_template()->HasInstance(args[0])) {
return THROW_ERR_INVALID_ARG_TYPE(env, return THROW_ERR_INVALID_ARG_TYPE(env,
"First argument needs to be a MessagePort instance"); "The \"port\" argument must be a MessagePort instance");
} }
MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>()); MessagePort* port = Unwrap<MessagePort>(args[0].As<Object>());
CHECK_NOT_NULL(port); CHECK_NOT_NULL(port);

2
test/parallel/test-worker-message-port-receive-message.js
View File

@ -28,6 +28,6 @@ for (const value of [null, 0, -1, {}, []]) {
assert.throws(() => receiveMessageOnPort(value), { assert.throws(() => receiveMessageOnPort(value), {
name: 'TypeError', name: 'TypeError',
code: 'ERR_INVALID_ARG_TYPE', code: 'ERR_INVALID_ARG_TYPE',
message: 'First argument needs to be a MessagePort instance' message: 'The "port" argument must be a MessagePort instance'
}); });
} }