lib,permission: restrict process.binding when pm is enabled

PR-URL: https://github.com/nodejs-private/node-private/pull/438
Fixes: https://github.com/nodejs-private/node-private/issues/422
CVE-ID: CVE-2023-32558
This commit is contained in:
RafaelGSS 2023-06-27 10:44:56 -03:00
parent ae25da20fa
commit bd7443ad0a
3 changed files with 58 additions and 0 deletions

View File

@ -33,6 +33,7 @@ const {
ERR_MANIFEST_ASSERT_INTEGRITY, ERR_MANIFEST_ASSERT_INTEGRITY,
ERR_NO_CRYPTO, ERR_NO_CRYPTO,
ERR_MISSING_OPTION, ERR_MISSING_OPTION,
ERR_ACCESS_DENIED,
} = require('internal/errors').codes; } = require('internal/errors').codes;
const assert = require('internal/assert'); const assert = require('internal/assert');
const { const {
@ -536,6 +537,9 @@ function initializeClusterIPC() {
function initializePermission() { function initializePermission() {
const experimentalPermission = getOptionValue('--experimental-permission'); const experimentalPermission = getOptionValue('--experimental-permission');
if (experimentalPermission) { if (experimentalPermission) {
process.binding = function binding(_module) {
throw new ERR_ACCESS_DENIED('process.binding');
};
process.emitWarning('Permission is an experimental feature', process.emitWarning('Permission is an experimental feature',
'ExperimentalWarning'); 'ExperimentalWarning');
const { has, deny } = require('internal/process/permission'); const { has, deny } = require('internal/process/permission');

View File

@ -0,0 +1,28 @@
const common = require('../../common');
common.skipIfWorker();
const assert = require('assert');
{
assert.throws(() => {
process.binding();
}, common.expectsError({
code: 'ERR_ACCESS_DENIED',
}));
}
{
assert.throws(() => {
process.binding('async_wrap');
}, common.expectsError({
code: 'ERR_ACCESS_DENIED',
}));
}
{
assert.throws(() => {
process.binding('fs');
}, common.expectsError({
code: 'ERR_ACCESS_DENIED',
}));
}

View File

@ -0,0 +1,26 @@
'use strict';
const common = require('../common');
common.skipIfWorker();
if (!common.hasCrypto) {
common.skip('no crypto');
}
const { spawnSync } = require('child_process');
const assert = require('assert');
const fixtures = require('../common/fixtures');
const file = fixtures.path('permission', 'processbinding.js');
// Due to linting rules-utils.js:isBinding check, process.binding() should
// not be called when --experimental-permission is enabled.
// Always spawn a child process
{
const { status, stderr } = spawnSync(
process.execPath,
[
'--experimental-permission', '--allow-fs-read=*', file,
],
);
assert.strictEqual(status, 0, stderr.toString());
}