jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-03 01:31:27 +00:00
Code Issues Actions 21 Packages Projects Releases Wiki Activity

test: fix flaky test-http-client-get-url

Browse Source 
Fixed test-http-client-get-url by waiting on HTTP GET
requests to finish before closing the server.

PR-URL: https://github.com/nodejs/node/pull/13516
Fixes: https://github.com/nodejs/node/issues/13507
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This commit is contained in:
Sebastian Plesciuc 2017-06-07 14:56:20 +03:00 committed by Refael Ackermann
parent a08b59f2a6
commit 61adb264c0
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
test/parallel/test-http-client-get-url.js
View File

@ -25,19 +25,23 @@ const assert = require('assert');
const http = require('http');
const url = require('url');
const URL = url.URL;
const testPath = '/foo?bar';
const server = http.createServer(common.mustCall(function(req, res) {
const server = http.createServer(common.mustCall((req, res) => {
assert.strictEqual('GET', req.method);
assert.strictEqual('/foo?bar', req.url);
assert.strictEqual(testPath, req.url);
res.writeHead(200, {'Content-Type': 'text/plain'});
res.write('hello\n');
res.end();
server.close();
}, 3));
server.listen(0, function() {
const u = `http://127.0.0.1:${this.address().port}/foo?bar`;
http.get(u);
http.get(url.parse(u));
http.get(new URL(u));
});
server.listen(0, common.localhostIPv4, common.mustCall(() => {
const u = `http://${common.localhostIPv4}:${server.address().port}${testPath}`;
http.get(u, common.mustCall(() => {
http.get(url.parse(u), common.mustCall(() => {
http.get(new URL(u), common.mustCall(() => {
server.close();
}));
}));
}));
}));