jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-16 07:06:47 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

test: don't assume broadcast traffic is unfiltered

Browse Source 
parallel/test-dgram-broadcast-multi-process assumes non-local broadcast
traffic is unfiltered, an assumption that fails with, for example, the
default Fedora firewall rules.  Use a loopback interface instead.

Fixes: https://github.com/iojs/io.js/issues/219
PR-URL: https://github.com/iojs/io.js/pull/220
Reviewed-By: Fedor Indutny <fedor@indutny.com>
This commit is contained in:
Ben Noordhuis 2014-12-29 17:35:51 +01:00
parent eaed2a11ec
commit 52e600a9c8
1 changed files with 2 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/parallel/test-dgram-broadcast-multi-process.js
View File

@ -23,7 +23,6 @@ var common = require('../common'),
assert = require('assert'),
dgram = require('dgram'),
util = require('util'),
networkInterfaces = require('os').networkInterfaces(),
Buffer = require('buffer').Buffer,
fork = require('child_process').fork,
LOCAL_BROADCAST_HOST = '255.255.255.255',
@ -35,19 +34,6 @@ var common = require('../common'),
new Buffer('Fourth message to send')
];
// take the first non-internal interface as the address for binding
get_bindAddress: for (var name in networkInterfaces) {
var interfaces = networkInterfaces[name];
for(var i = 0; i < interfaces.length; i++) {
var localInterface = interfaces[i];
if (!localInterface.internal && localInterface.family === 'IPv4') {
var bindAddress = localInterface.address;
break get_bindAddress;
}
}
}
assert.ok(bindAddress);
if (process.argv[2] !== 'child') {
var workers = {},
listeners = 3,
@ -164,7 +150,7 @@ if (process.argv[2] !== 'child') {
// bind the address explicitly for sending
// INADDR_BROADCAST to only one interface
sendSocket.bind(common.PORT, bindAddress);
sendSocket.bind(common.PORT, '127.0.0.1');
sendSocket.on('listening', function () {
sendSocket.setBroadcast(true);
});
@ -211,7 +197,7 @@ if (process.argv[2] === 'child') {
listenSocket.on('message', function(buf, rinfo) {
// receive udp messages only sent from parent
if (rinfo.address !== bindAddress) return;
if (rinfo.address !== '127.0.0.1') return;
console.error('[CHILD] %s received %s from %j',
process.pid,