jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-04-28 13:40:37 +00:00
Code Issues Actions 19 Packages Projects Releases Wiki Activity

stream: preserve AsyncLocalStorage context in finished()

Browse Source 
PR-URL: https://github.com/nodejs/node/pull/57865
Reviewed-By: Raz Luvaton <rluvaton@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
This commit is contained in:
Gürgün Dayıoğlu 2025-04-16 11:27:37 +02:00 committed by GitHub
parent 91d8a524ad
commit 4b2b3c01b4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 25 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/internal/streams/end-of-stream.js
View File

@ -43,6 +43,9 @@ const {
willEmitClose: _willEmitClose,
kIsClosedPromise,
} = require('internal/streams/utils');
// Lazy load
let AsyncLocalStorage;
let addAbortListener;
function isRequest(stream) {
@ -63,7 +66,8 @@ function eos(stream, options, callback) {
validateFunction(callback, 'callback');
validateAbortSignal(options.signal, 'options.signal');
callback = once(callback);
AsyncLocalStorage ??= require('async_hooks').AsyncLocalStorage;
callback = once(AsyncLocalStorage.bind(callback));
if (isReadableStream(stream) || isWritableStream(stream)) {
return eosWeb(stream, options, callback);

20
test/async-hooks/test-async-local-storage-stream-finished.js Normal file
View File

@ -0,0 +1,20 @@
'use strict';
const common = require('../common');
const { Readable, finished } = require('stream');
const { AsyncLocalStorage } = require('async_hooks');
const { strictEqual } = require('assert');
// This test verifies that AsyncLocalStorage context is maintained
// when using stream.finished()
const readable = new Readable();
const als = new AsyncLocalStorage();
als.run(321, () => {
finished(readable, common.mustCall(() => {
strictEqual(als.getStore(), 321);
}));
});
readable.destroy();