jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-01 17:03:34 +00:00
Code Issues Actions 25 Packages Projects Releases Wiki Activity

test: update V8 trace events test expectations

Browse Source 
The event "V8.GCScavenger" is soon to be deprecated. Most of V8
trace events are either behind flags and disabled by default, or
are emitted infrequently. Instead of replacing "V8.GCScavenger"
with some other random event, this patch updates the tests to
check that there is some event in the category "v8" whose name
starts with "V8.".

PR-URL: https://github.com/nodejs/node/pull/42120
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This commit is contained in:
Nikolaos Papaspyrou 2022-02-24 19:19:35 +01:00 committed by Michaël Zasso
parent ce1c53665e
commit 3ba41246d2
No known key found for this signature in database
GPG Key ID: 770F7A9A5AE15600
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
test/parallel/test-trace-events-all.js
View File

@ -27,7 +27,7 @@ proc.once('exit', common.mustCall(() => {
return false;
if (trace.cat !== 'v8')
return false;
if (trace.name !== 'V8.GCScavenger')
if (!trace.name.startsWith('V8.'))
return false;
return true;
}));

2
test/parallel/test-trace-events-v8.js
View File

@ -29,7 +29,7 @@ proc.once('exit', common.mustCall(() => {
return false;
if (trace.cat !== 'v8')
return false;
if (trace.name !== 'V8.GCScavenger')
if (!trace.name.startsWith('V8.'))
return false;
return true;
}));