jiangcuo/node
1
0
Fork 0
mirror of https://github.com/nodejs/node.git synced 2025-05-09 01:30:25 +00:00
Code Issues Actions 12 Packages Projects Releases Wiki Activity

test: fix exec-after-fork race in test/simple/test-child-process-kill.js

Browse Source
This commit is contained in:
Ben Noordhuis 2011-08-03 16:05:49 +02:00
parent 09bb1d64dc
commit 12c8b27e24
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
test/simple/test-child-process-kill.js
View File

@ -29,11 +29,25 @@ var termSignal;
var gotStdoutEOF = false; var gotStdoutEOF = false;
var gotStderrEOF = false; var gotStderrEOF = false;
var ping = "42\n";
var cat = spawn('cat'); var cat = spawn('cat');
//
// This test sends a signal to a child process.
//
// There is a potential race here where the signal is delivered
// after the fork() but before execve(). IOW, the signal is sent
// before the child process has truly been started.
//
// So we wait for a sign of life from the child (the ping response)
// before sending the signal.
//
cat.stdin.write(ping);
cat.stdout.addListener('data', function(chunk) { cat.stdout.addListener('data', function(chunk) {
assert.ok(false); assert.equal(chunk.toString(), ping);
cat.kill();
}); });
cat.stdout.addListener('end', function() { cat.stdout.addListener('end', function() {
@ -53,8 +67,6 @@ cat.addListener('exit', function(code, signal) {
termSignal = signal; termSignal = signal;
}); });
cat.kill();
process.addListener('exit', function() { process.addListener('exit', function() {
assert.strictEqual(exitCode, null); assert.strictEqual(exitCode, null);
assert.strictEqual(termSignal, 'SIGTERM'); assert.strictEqual(termSignal, 'SIGTERM');