mirror of
https://github.com/openzfs/zfs.git
synced 2025-10-01 11:26:49 +00:00
6ce97bb4a2
This:
(a) improves the error log message,
(b) locks per pool instead of globally,
(c) locks the actual output file instead of /var/lock/zfs-list,
which would otherwise linger there forever (well, still will,
but you can remove it and it won't come back), and
(d) preserves attributes of the output file
instead of reverting them to 0:0 644
It is imperative that the previous commit
("zed-functions.sh: zed_lock(): don't truncate lock")
be included in any series that contains this one
Reviewed-by: Tony Hutter <hutter2@llnl.gov>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Ahelenia Ziemiańska <nabijaczleweli@nabijaczleweli.xyz>
Closes #12042
85 lines
2.5 KiB
Bash
Executable File
85 lines
2.5 KiB
Bash
Executable File
#!/bin/sh
|
|
#
|
|
# Track changes to enumerated pools for use in early-boot
|
|
set -ef
|
|
|
|
FSLIST="@sysconfdir@/zfs/zfs-list.cache/${ZEVENT_POOL}"
|
|
FSLIST_TMP="@runstatedir@/zfs-list.cache@${ZEVENT_POOL}"
|
|
|
|
# If the pool specific cache file is not writeable, abort
|
|
[ -w "${FSLIST}" ] || exit 0
|
|
|
|
[ -f "${ZED_ZEDLET_DIR}/zed.rc" ] && . "${ZED_ZEDLET_DIR}/zed.rc"
|
|
. "${ZED_ZEDLET_DIR}/zed-functions.sh"
|
|
|
|
[ "$ZEVENT_SUBCLASS" != "history_event" ] && exit 0
|
|
zed_check_cmd "${ZFS}" sort diff
|
|
|
|
# If we are acting on a snapshot, we have nothing to do
|
|
[ "${ZEVENT_HISTORY_DSNAME%@*}" = "${ZEVENT_HISTORY_DSNAME}" ] || exit 0
|
|
|
|
# We lock the output file to avoid simultaneous writes.
|
|
# If we run into trouble, log and drop the lock
|
|
abort_alter() {
|
|
zed_log_msg "Error updating zfs-list.cache for ${ZEVENT_POOL}!"
|
|
zed_unlock "${FSLIST}"
|
|
}
|
|
|
|
finished() {
|
|
zed_unlock "${FSLIST}"
|
|
trap - EXIT
|
|
exit 0
|
|
}
|
|
|
|
case "${ZEVENT_HISTORY_INTERNAL_NAME}" in
|
|
create|"finish receiving"|import|destroy|rename)
|
|
;;
|
|
|
|
export)
|
|
zed_lock "${FSLIST}"
|
|
trap abort_alter EXIT
|
|
echo > "${FSLIST}"
|
|
finished
|
|
;;
|
|
|
|
set|inherit)
|
|
# Only act if one of the tracked properties is altered.
|
|
case "${ZEVENT_HISTORY_INTERNAL_STR%%=*}" in
|
|
canmount|mountpoint|atime|relatime|devices|exec|readonly| \
|
|
setuid|nbmand|encroot|keylocation|org.openzfs.systemd:requires| \
|
|
org.openzfs.systemd:requires-mounts-for| \
|
|
org.openzfs.systemd:before|org.openzfs.systemd:after| \
|
|
org.openzfs.systemd:wanted-by|org.openzfs.systemd:required-by| \
|
|
org.openzfs.systemd:nofail|org.openzfs.systemd:ignore \
|
|
) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
;;
|
|
|
|
*)
|
|
# Ignore all other events.
|
|
exit 0
|
|
;;
|
|
esac
|
|
|
|
zed_lock "${FSLIST}"
|
|
trap abort_alter EXIT
|
|
|
|
PROPS="name,mountpoint,canmount,atime,relatime,devices,exec\
|
|
,readonly,setuid,nbmand,encroot,keylocation\
|
|
,org.openzfs.systemd:requires,org.openzfs.systemd:requires-mounts-for\
|
|
,org.openzfs.systemd:before,org.openzfs.systemd:after\
|
|
,org.openzfs.systemd:wanted-by,org.openzfs.systemd:required-by\
|
|
,org.openzfs.systemd:nofail,org.openzfs.systemd:ignore"
|
|
|
|
"${ZFS}" list -H -t filesystem -o $PROPS -r "${ZEVENT_POOL}" > "${FSLIST_TMP}"
|
|
|
|
# Sort the output so that it is stable
|
|
sort "${FSLIST_TMP}" -o "${FSLIST_TMP}"
|
|
|
|
# Don't modify the file if it hasn't changed
|
|
diff -q "${FSLIST_TMP}" "${FSLIST}" || cat "${FSLIST_TMP}" > "${FSLIST}"
|
|
rm -f "${FSLIST_TMP}"
|
|
|
|
finished
|