Proxmox-Port/swtpm
1
0
Fork 0
mirror of https://github.com/stefanberger/swtpm.git synced 2026-08-10 11:10:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

swtpm: Unconditionally close fd if writing of pidfile fails (coverity)

Browse Source 
Do not bother trying to keep pidfilefd open in case fd = pidfilefd,
but close it unconditionally. If writing the pidfile fails, the process
terminates anyway, besides that we only ever need to write to the
pidfile once, which is happening in this function.

Signed-off-by: Stefan Berger <stefanb@linux.ibm.com>
This commit is contained in:
Stefan Berger 2020-12-25 23:30:34 -05:00 committed by Stefan Berger
parent 2cb9f95680
commit 1dbde0a148
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/swtpm/pidfile.c
View File

@ -91,6 +91,8 @@ int pidfile_write(pid_t pid)
g_pidfile = fd_to_filename(pidfilefd);
if (!g_pidfile)
goto error;
pidfile_set_fd(-1); /* will be closed */
} else {
return 0;
}
@ -118,8 +120,7 @@ int pidfile_write(pid_t pid)
return 0;
error_close:
if (fd != pidfilefd)
close(fd);
close(fd);
error:
return -1;