mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 20:44:16 +00:00 
			
		
		
		
	 2362a28ea1
			
		
	
	
		2362a28ea1
		
	
	
	
	
		
			
			There is a small chance that iothread_stop() hangs as follows: Thread 3 (Thread 0x7f63eba5f700 (LWP 16105)): #0 0x00007f64012c09b6 in ppoll () at /lib64/libc.so.6 #1 0x000055959992eac9 in ppoll (__ss=0x0, __timeout=0x0, __nfds=<optimized out>, __fds=<optimized out>) at /usr/include/bits/poll2.h:77 #2 0x000055959992eac9 in qemu_poll_ns (fds=<optimized out>, nfds=<optimized out>, timeout=<optimized out>) at util/qemu-timer.c:322 #3 0x0000559599930711 in aio_poll (ctx=0x55959bdb83c0, blocking=blocking@entry=true) at util/aio-posix.c:629 #4 0x00005595996806fe in iothread_run (opaque=0x55959bd78400) at iothread.c:59 #5 0x00007f640159f609 in start_thread () at /lib64/libpthread.so.0 #6 0x00007f64012cce6f in clone () at /lib64/libc.so.6 Thread 1 (Thread 0x7f640b45b280 (LWP 16103)): #0 0x00007f64015a0b6d in pthread_join () at /lib64/libpthread.so.0 #1 0x00005595999332ef in qemu_thread_join (thread=<optimized out>) at util/qemu-thread-posix.c:547 #2 0x00005595996808ae in iothread_stop (iothread=<optimized out>) at iothread.c:91 #3 0x000055959968094d in iothread_stop_iter (object=<optimized out>, opaque=<optimized out>) at iothread.c:102 #4 0x0000559599857d97 in do_object_child_foreach (obj=obj@entry=0x55959bdb8100, fn=fn@entry=0x559599680930 <iothread_stop_iter>, opaque=opaque@entry=0x0, recurse=recurse@entry=false) at qom/object.c:852 #5 0x0000559599859477 in object_child_foreach (obj=obj@entry=0x55959bdb8100, fn=fn@entry=0x559599680930 <iothread_stop_iter>, opaque=opaque@entry=0x0) at qom/object.c:867 #6 0x0000559599680a6e in iothread_stop_all () at iothread.c:341 #7 0x000055959955b1d5 in main (argc=<optimized out>, argv=<optimized out>, envp=<optimized out>) at vl.c:4913 The relevant code from iothread_run() is: while (!atomic_read(&iothread->stopping)) { aio_poll(iothread->ctx, true); and iothread_stop(): iothread->stopping = true; aio_notify(iothread->ctx); ... qemu_thread_join(&iothread->thread); The following scenario can occur: 1. IOThread: while (!atomic_read(&iothread->stopping)) -> stopping=false 2. Main loop: iothread->stopping = true; aio_notify(iothread->ctx); 3. IOThread: aio_poll(iothread->ctx, true); -> hang The bug is explained by the AioContext->notify_me doc comments: "If this field is 0, everything (file descriptors, bottom halves, timers) will be re-evaluated before the next blocking poll(), thus the event_notifier_set call can be skipped." The problem is that "everything" does not include checking iothread->stopping. This means iothread_run() will block in aio_poll() if aio_notify() was called just before aio_poll(). This patch fixes the hang by replacing aio_notify() with aio_bh_schedule_oneshot(). This makes aio_poll() or g_main_loop_run() to return. Implementing this properly required a new bool running flag. The new flag prevents races that are tricky if we try to use iothread->stopping. Now iothread->stopping is purely for iothread_stop() and iothread->running is purely for the iothread_run() thread. Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Message-id: 20171207201320.19284-6-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
		
			
				
	
	
		
			400 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			400 lines
		
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Event loop thread
 | |
|  *
 | |
|  * Copyright Red Hat Inc., 2013
 | |
|  *
 | |
|  * Authors:
 | |
|  *  Stefan Hajnoczi   <stefanha@redhat.com>
 | |
|  *
 | |
|  * This work is licensed under the terms of the GNU GPL, version 2 or later.
 | |
|  * See the COPYING file in the top-level directory.
 | |
|  *
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| #include "qom/object.h"
 | |
| #include "qom/object_interfaces.h"
 | |
| #include "qemu/module.h"
 | |
| #include "block/aio.h"
 | |
| #include "block/block.h"
 | |
| #include "sysemu/iothread.h"
 | |
| #include "qmp-commands.h"
 | |
| #include "qemu/error-report.h"
 | |
| #include "qemu/rcu.h"
 | |
| #include "qemu/main-loop.h"
 | |
| 
 | |
| typedef ObjectClass IOThreadClass;
 | |
| 
 | |
| #define IOTHREAD_GET_CLASS(obj) \
 | |
|    OBJECT_GET_CLASS(IOThreadClass, obj, TYPE_IOTHREAD)
 | |
| #define IOTHREAD_CLASS(klass) \
 | |
|    OBJECT_CLASS_CHECK(IOThreadClass, klass, TYPE_IOTHREAD)
 | |
| 
 | |
| /* Benchmark results from 2016 on NVMe SSD drives show max polling times around
 | |
|  * 16-32 microseconds yield IOPS improvements for both iodepth=1 and iodepth=32
 | |
|  * workloads.
 | |
|  */
 | |
| #define IOTHREAD_POLL_MAX_NS_DEFAULT 32768ULL
 | |
| 
 | |
| static __thread IOThread *my_iothread;
 | |
| 
 | |
| AioContext *qemu_get_current_aio_context(void)
 | |
| {
 | |
|     return my_iothread ? my_iothread->ctx : qemu_get_aio_context();
 | |
| }
 | |
| 
 | |
| static void *iothread_run(void *opaque)
 | |
| {
 | |
|     IOThread *iothread = opaque;
 | |
| 
 | |
|     rcu_register_thread();
 | |
| 
 | |
|     my_iothread = iothread;
 | |
|     qemu_mutex_lock(&iothread->init_done_lock);
 | |
|     iothread->thread_id = qemu_get_thread_id();
 | |
|     qemu_cond_signal(&iothread->init_done_cond);
 | |
|     qemu_mutex_unlock(&iothread->init_done_lock);
 | |
| 
 | |
|     while (iothread->running) {
 | |
|         aio_poll(iothread->ctx, true);
 | |
| 
 | |
|         if (atomic_read(&iothread->worker_context)) {
 | |
|             GMainLoop *loop;
 | |
| 
 | |
|             g_main_context_push_thread_default(iothread->worker_context);
 | |
|             iothread->main_loop =
 | |
|                 g_main_loop_new(iothread->worker_context, TRUE);
 | |
|             loop = iothread->main_loop;
 | |
| 
 | |
|             g_main_loop_run(iothread->main_loop);
 | |
|             iothread->main_loop = NULL;
 | |
|             g_main_loop_unref(loop);
 | |
| 
 | |
|             g_main_context_pop_thread_default(iothread->worker_context);
 | |
|         }
 | |
|     }
 | |
| 
 | |
|     rcu_unregister_thread();
 | |
|     return NULL;
 | |
| }
 | |
| 
 | |
| /* Runs in iothread_run() thread */
 | |
| static void iothread_stop_bh(void *opaque)
 | |
| {
 | |
|     IOThread *iothread = opaque;
 | |
| 
 | |
|     iothread->running = false; /* stop iothread_run() */
 | |
| 
 | |
|     if (iothread->main_loop) {
 | |
|         g_main_loop_quit(iothread->main_loop);
 | |
|     }
 | |
| }
 | |
| 
 | |
| void iothread_stop(IOThread *iothread)
 | |
| {
 | |
|     if (!iothread->ctx || iothread->stopping) {
 | |
|         return;
 | |
|     }
 | |
|     iothread->stopping = true;
 | |
|     aio_bh_schedule_oneshot(iothread->ctx, iothread_stop_bh, iothread);
 | |
|     qemu_thread_join(&iothread->thread);
 | |
| }
 | |
| 
 | |
| static int iothread_stop_iter(Object *object, void *opaque)
 | |
| {
 | |
|     IOThread *iothread;
 | |
| 
 | |
|     iothread = (IOThread *)object_dynamic_cast(object, TYPE_IOTHREAD);
 | |
|     if (!iothread) {
 | |
|         return 0;
 | |
|     }
 | |
|     iothread_stop(iothread);
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| static void iothread_instance_init(Object *obj)
 | |
| {
 | |
|     IOThread *iothread = IOTHREAD(obj);
 | |
| 
 | |
|     iothread->poll_max_ns = IOTHREAD_POLL_MAX_NS_DEFAULT;
 | |
| }
 | |
| 
 | |
| static void iothread_instance_finalize(Object *obj)
 | |
| {
 | |
|     IOThread *iothread = IOTHREAD(obj);
 | |
| 
 | |
|     iothread_stop(iothread);
 | |
|     if (iothread->worker_context) {
 | |
|         g_main_context_unref(iothread->worker_context);
 | |
|         iothread->worker_context = NULL;
 | |
|     }
 | |
|     qemu_cond_destroy(&iothread->init_done_cond);
 | |
|     qemu_mutex_destroy(&iothread->init_done_lock);
 | |
|     if (!iothread->ctx) {
 | |
|         return;
 | |
|     }
 | |
|     aio_context_unref(iothread->ctx);
 | |
| }
 | |
| 
 | |
| static void iothread_complete(UserCreatable *obj, Error **errp)
 | |
| {
 | |
|     Error *local_error = NULL;
 | |
|     IOThread *iothread = IOTHREAD(obj);
 | |
|     char *name, *thread_name;
 | |
| 
 | |
|     iothread->stopping = false;
 | |
|     iothread->running = true;
 | |
|     iothread->thread_id = -1;
 | |
|     iothread->ctx = aio_context_new(&local_error);
 | |
|     if (!iothread->ctx) {
 | |
|         error_propagate(errp, local_error);
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     aio_context_set_poll_params(iothread->ctx,
 | |
|                                 iothread->poll_max_ns,
 | |
|                                 iothread->poll_grow,
 | |
|                                 iothread->poll_shrink,
 | |
|                                 &local_error);
 | |
|     if (local_error) {
 | |
|         error_propagate(errp, local_error);
 | |
|         aio_context_unref(iothread->ctx);
 | |
|         iothread->ctx = NULL;
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     qemu_mutex_init(&iothread->init_done_lock);
 | |
|     qemu_cond_init(&iothread->init_done_cond);
 | |
|     iothread->once = (GOnce) G_ONCE_INIT;
 | |
| 
 | |
|     /* This assumes we are called from a thread with useful CPU affinity for us
 | |
|      * to inherit.
 | |
|      */
 | |
|     name = object_get_canonical_path_component(OBJECT(obj));
 | |
|     thread_name = g_strdup_printf("IO %s", name);
 | |
|     qemu_thread_create(&iothread->thread, thread_name, iothread_run,
 | |
|                        iothread, QEMU_THREAD_JOINABLE);
 | |
|     g_free(thread_name);
 | |
|     g_free(name);
 | |
| 
 | |
|     /* Wait for initialization to complete */
 | |
|     qemu_mutex_lock(&iothread->init_done_lock);
 | |
|     while (iothread->thread_id == -1) {
 | |
|         qemu_cond_wait(&iothread->init_done_cond,
 | |
|                        &iothread->init_done_lock);
 | |
|     }
 | |
|     qemu_mutex_unlock(&iothread->init_done_lock);
 | |
| }
 | |
| 
 | |
| typedef struct {
 | |
|     const char *name;
 | |
|     ptrdiff_t offset; /* field's byte offset in IOThread struct */
 | |
| } PollParamInfo;
 | |
| 
 | |
| static PollParamInfo poll_max_ns_info = {
 | |
|     "poll-max-ns", offsetof(IOThread, poll_max_ns),
 | |
| };
 | |
| static PollParamInfo poll_grow_info = {
 | |
|     "poll-grow", offsetof(IOThread, poll_grow),
 | |
| };
 | |
| static PollParamInfo poll_shrink_info = {
 | |
|     "poll-shrink", offsetof(IOThread, poll_shrink),
 | |
| };
 | |
| 
 | |
| static void iothread_get_poll_param(Object *obj, Visitor *v,
 | |
|         const char *name, void *opaque, Error **errp)
 | |
| {
 | |
|     IOThread *iothread = IOTHREAD(obj);
 | |
|     PollParamInfo *info = opaque;
 | |
|     int64_t *field = (void *)iothread + info->offset;
 | |
| 
 | |
|     visit_type_int64(v, name, field, errp);
 | |
| }
 | |
| 
 | |
| static void iothread_set_poll_param(Object *obj, Visitor *v,
 | |
|         const char *name, void *opaque, Error **errp)
 | |
| {
 | |
|     IOThread *iothread = IOTHREAD(obj);
 | |
|     PollParamInfo *info = opaque;
 | |
|     int64_t *field = (void *)iothread + info->offset;
 | |
|     Error *local_err = NULL;
 | |
|     int64_t value;
 | |
| 
 | |
|     visit_type_int64(v, name, &value, &local_err);
 | |
|     if (local_err) {
 | |
|         goto out;
 | |
|     }
 | |
| 
 | |
|     if (value < 0) {
 | |
|         error_setg(&local_err, "%s value must be in range [0, %"PRId64"]",
 | |
|                    info->name, INT64_MAX);
 | |
|         goto out;
 | |
|     }
 | |
| 
 | |
|     *field = value;
 | |
| 
 | |
|     if (iothread->ctx) {
 | |
|         aio_context_set_poll_params(iothread->ctx,
 | |
|                                     iothread->poll_max_ns,
 | |
|                                     iothread->poll_grow,
 | |
|                                     iothread->poll_shrink,
 | |
|                                     &local_err);
 | |
|     }
 | |
| 
 | |
| out:
 | |
|     error_propagate(errp, local_err);
 | |
| }
 | |
| 
 | |
| static void iothread_class_init(ObjectClass *klass, void *class_data)
 | |
| {
 | |
|     UserCreatableClass *ucc = USER_CREATABLE_CLASS(klass);
 | |
|     ucc->complete = iothread_complete;
 | |
| 
 | |
|     object_class_property_add(klass, "poll-max-ns", "int",
 | |
|                               iothread_get_poll_param,
 | |
|                               iothread_set_poll_param,
 | |
|                               NULL, &poll_max_ns_info, &error_abort);
 | |
|     object_class_property_add(klass, "poll-grow", "int",
 | |
|                               iothread_get_poll_param,
 | |
|                               iothread_set_poll_param,
 | |
|                               NULL, &poll_grow_info, &error_abort);
 | |
|     object_class_property_add(klass, "poll-shrink", "int",
 | |
|                               iothread_get_poll_param,
 | |
|                               iothread_set_poll_param,
 | |
|                               NULL, &poll_shrink_info, &error_abort);
 | |
| }
 | |
| 
 | |
| static const TypeInfo iothread_info = {
 | |
|     .name = TYPE_IOTHREAD,
 | |
|     .parent = TYPE_OBJECT,
 | |
|     .class_init = iothread_class_init,
 | |
|     .instance_size = sizeof(IOThread),
 | |
|     .instance_init = iothread_instance_init,
 | |
|     .instance_finalize = iothread_instance_finalize,
 | |
|     .interfaces = (InterfaceInfo[]) {
 | |
|         {TYPE_USER_CREATABLE},
 | |
|         {}
 | |
|     },
 | |
| };
 | |
| 
 | |
| static void iothread_register_types(void)
 | |
| {
 | |
|     type_register_static(&iothread_info);
 | |
| }
 | |
| 
 | |
| type_init(iothread_register_types)
 | |
| 
 | |
| char *iothread_get_id(IOThread *iothread)
 | |
| {
 | |
|     return object_get_canonical_path_component(OBJECT(iothread));
 | |
| }
 | |
| 
 | |
| AioContext *iothread_get_aio_context(IOThread *iothread)
 | |
| {
 | |
|     return iothread->ctx;
 | |
| }
 | |
| 
 | |
| static int query_one_iothread(Object *object, void *opaque)
 | |
| {
 | |
|     IOThreadInfoList ***prev = opaque;
 | |
|     IOThreadInfoList *elem;
 | |
|     IOThreadInfo *info;
 | |
|     IOThread *iothread;
 | |
| 
 | |
|     iothread = (IOThread *)object_dynamic_cast(object, TYPE_IOTHREAD);
 | |
|     if (!iothread) {
 | |
|         return 0;
 | |
|     }
 | |
| 
 | |
|     info = g_new0(IOThreadInfo, 1);
 | |
|     info->id = iothread_get_id(iothread);
 | |
|     info->thread_id = iothread->thread_id;
 | |
|     info->poll_max_ns = iothread->poll_max_ns;
 | |
|     info->poll_grow = iothread->poll_grow;
 | |
|     info->poll_shrink = iothread->poll_shrink;
 | |
| 
 | |
|     elem = g_new0(IOThreadInfoList, 1);
 | |
|     elem->value = info;
 | |
|     elem->next = NULL;
 | |
| 
 | |
|     **prev = elem;
 | |
|     *prev = &elem->next;
 | |
|     return 0;
 | |
| }
 | |
| 
 | |
| IOThreadInfoList *qmp_query_iothreads(Error **errp)
 | |
| {
 | |
|     IOThreadInfoList *head = NULL;
 | |
|     IOThreadInfoList **prev = &head;
 | |
|     Object *container = object_get_objects_root();
 | |
| 
 | |
|     object_child_foreach(container, query_one_iothread, &prev);
 | |
|     return head;
 | |
| }
 | |
| 
 | |
| void iothread_stop_all(void)
 | |
| {
 | |
|     Object *container = object_get_objects_root();
 | |
|     BlockDriverState *bs;
 | |
|     BdrvNextIterator it;
 | |
| 
 | |
|     for (bs = bdrv_first(&it); bs; bs = bdrv_next(&it)) {
 | |
|         AioContext *ctx = bdrv_get_aio_context(bs);
 | |
|         if (ctx == qemu_get_aio_context()) {
 | |
|             continue;
 | |
|         }
 | |
|         aio_context_acquire(ctx);
 | |
|         bdrv_set_aio_context(bs, qemu_get_aio_context());
 | |
|         aio_context_release(ctx);
 | |
|     }
 | |
| 
 | |
|     object_child_foreach(container, iothread_stop_iter, NULL);
 | |
| }
 | |
| 
 | |
| static gpointer iothread_g_main_context_init(gpointer opaque)
 | |
| {
 | |
|     AioContext *ctx;
 | |
|     IOThread *iothread = opaque;
 | |
|     GSource *source;
 | |
| 
 | |
|     iothread->worker_context = g_main_context_new();
 | |
| 
 | |
|     ctx = iothread_get_aio_context(iothread);
 | |
|     source = aio_get_g_source(ctx);
 | |
|     g_source_attach(source, iothread->worker_context);
 | |
|     g_source_unref(source);
 | |
| 
 | |
|     aio_notify(iothread->ctx);
 | |
|     return NULL;
 | |
| }
 | |
| 
 | |
| GMainContext *iothread_get_g_main_context(IOThread *iothread)
 | |
| {
 | |
|     g_once(&iothread->once, iothread_g_main_context_init, iothread);
 | |
| 
 | |
|     return iothread->worker_context;
 | |
| }
 | |
| 
 | |
| IOThread *iothread_create(const char *id, Error **errp)
 | |
| {
 | |
|     Object *obj;
 | |
| 
 | |
|     obj = object_new_with_props(TYPE_IOTHREAD,
 | |
|                                 object_get_internal_root(),
 | |
|                                 id, errp, NULL);
 | |
| 
 | |
|     return IOTHREAD(obj);
 | |
| }
 | |
| 
 | |
| void iothread_destroy(IOThread *iothread)
 | |
| {
 | |
|     object_unparent(OBJECT(iothread));
 | |
| }
 | |
| 
 | |
| /* Lookup IOThread by its id.  Only finds user-created objects, not internal
 | |
|  * iothread_create() objects. */
 | |
| IOThread *iothread_by_id(const char *id)
 | |
| {
 | |
|     return IOTHREAD(object_resolve_path_type(id, TYPE_IOTHREAD, NULL));
 | |
| }
 |