mirror of
https://github.com/qemu/qemu.git
synced 2025-10-31 20:44:16 +00:00
a0c167a184
Starting qemu with
qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu
leads to a segfault. The code assume PCI bus is present and
tries to access the bus structure without checking.
Since Intel VT-d and AMDVI should only work with PCI, add a
check for PCI bus and return error if not present.
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
133 lines
3.7 KiB
C
133 lines
3.7 KiB
C
/*
|
|
* QEMU emulation of common X86 IOMMU
|
|
*
|
|
* Copyright (C) 2016 Peter Xu, Red Hat <peterx@redhat.com>
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/sysbus.h"
|
|
#include "hw/boards.h"
|
|
#include "hw/i386/x86-iommu.h"
|
|
#include "hw/i386/pc.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/error-report.h"
|
|
#include "trace.h"
|
|
|
|
void x86_iommu_iec_register_notifier(X86IOMMUState *iommu,
|
|
iec_notify_fn fn, void *data)
|
|
{
|
|
IEC_Notifier *notifier = g_new0(IEC_Notifier, 1);
|
|
|
|
notifier->iec_notify = fn;
|
|
notifier->private = data;
|
|
|
|
QLIST_INSERT_HEAD(&iommu->iec_notifiers, notifier, list);
|
|
}
|
|
|
|
void x86_iommu_iec_notify_all(X86IOMMUState *iommu, bool global,
|
|
uint32_t index, uint32_t mask)
|
|
{
|
|
IEC_Notifier *notifier;
|
|
|
|
trace_x86_iommu_iec_notify(global, index, mask);
|
|
|
|
QLIST_FOREACH(notifier, &iommu->iec_notifiers, list) {
|
|
if (notifier->iec_notify) {
|
|
notifier->iec_notify(notifier->private, global,
|
|
index, mask);
|
|
}
|
|
}
|
|
}
|
|
|
|
/* Default X86 IOMMU device */
|
|
static X86IOMMUState *x86_iommu_default = NULL;
|
|
|
|
static void x86_iommu_set_default(X86IOMMUState *x86_iommu)
|
|
{
|
|
assert(x86_iommu);
|
|
|
|
if (x86_iommu_default) {
|
|
error_report("QEMU does not support multiple vIOMMUs "
|
|
"for x86 yet.");
|
|
exit(1);
|
|
}
|
|
|
|
x86_iommu_default = x86_iommu;
|
|
}
|
|
|
|
X86IOMMUState *x86_iommu_get_default(void)
|
|
{
|
|
return x86_iommu_default;
|
|
}
|
|
|
|
IommuType x86_iommu_get_type(void)
|
|
{
|
|
return x86_iommu_default->type;
|
|
}
|
|
|
|
static void x86_iommu_realize(DeviceState *dev, Error **errp)
|
|
{
|
|
X86IOMMUState *x86_iommu = X86_IOMMU_DEVICE(dev);
|
|
X86IOMMUClass *x86_class = X86_IOMMU_GET_CLASS(dev);
|
|
MachineState *ms = MACHINE(qdev_get_machine());
|
|
MachineClass *mc = MACHINE_GET_CLASS(ms);
|
|
PCMachineState *pcms =
|
|
PC_MACHINE(object_dynamic_cast(OBJECT(ms), TYPE_PC_MACHINE));
|
|
QLIST_INIT(&x86_iommu->iec_notifiers);
|
|
|
|
if (!pcms || !pcms->bus) {
|
|
error_setg(errp, "Machine-type '%s' not supported by IOMMU",
|
|
mc->name);
|
|
return;
|
|
}
|
|
|
|
if (x86_class->realize) {
|
|
x86_class->realize(dev, errp);
|
|
}
|
|
|
|
x86_iommu_set_default(X86_IOMMU_DEVICE(dev));
|
|
}
|
|
|
|
static Property x86_iommu_properties[] = {
|
|
DEFINE_PROP_BOOL("intremap", X86IOMMUState, intr_supported, false),
|
|
DEFINE_PROP_BOOL("device-iotlb", X86IOMMUState, dt_supported, false),
|
|
DEFINE_PROP_BOOL("pt", X86IOMMUState, pt_supported, true),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void x86_iommu_class_init(ObjectClass *klass, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(klass);
|
|
dc->realize = x86_iommu_realize;
|
|
dc->props = x86_iommu_properties;
|
|
}
|
|
|
|
static const TypeInfo x86_iommu_info = {
|
|
.name = TYPE_X86_IOMMU_DEVICE,
|
|
.parent = TYPE_SYS_BUS_DEVICE,
|
|
.instance_size = sizeof(X86IOMMUState),
|
|
.class_init = x86_iommu_class_init,
|
|
.class_size = sizeof(X86IOMMUClass),
|
|
.abstract = true,
|
|
};
|
|
|
|
static void x86_iommu_register_types(void)
|
|
{
|
|
type_register_static(&x86_iommu_info);
|
|
}
|
|
|
|
type_init(x86_iommu_register_types)
|