Peter Maydell e0784d8375 hw/net/can/ctucan: Avoid unused value in ctucan_send_ready_buffers() ... Coverity points out that in ctucan_send_ready_buffers() we set buff_st_mask = 0xf << (i * 4) inside the loop, but then we never use it before overwriting it later. The only thing we use the mask for is as part of the code that is inserting the new buff_st field into tx_status. That is more comprehensibly written using deposit32(), so do that and drop the mask variable entirely. We also update the buff_st local variable at multiple points during this function, but nothing can ever see these intermediate values, so just drop those, write the final TXT_TOK as a fixed constant value, and collapse the only remaining set/use of buff_st down into an extract32(). Fixes: Coverity CID 1432869 Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz> Tested-by: Pavel Pisa <pisa@cmp.felk.cvut.cz> Signed-off-by: Jason Wang <jasowang@redhat.com>		2020-11-11 20:34:36 +08:00
..
can_kvaser_pci.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
can_mioe3680_pci.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
can_pcm3680_pci.c	Use DECLARE_*CHECKER* macros	2020-09-09 09:27:09 -04:00
can_sja1000.c	hw/net/can: sja1000 ignore CAN FD frames	2020-09-30 19:11:36 +02:00
can_sja1000.h	hw/net/can: Make CanBusClientInfo::can_receive() return a boolean	2020-03-31 21:14:35 +08:00
ctu_can_fd_frame.h	hw/net/can/ctucafd: Add CTU CAN FD core register definitions.	2020-09-30 19:11:37 +02:00
ctu_can_fd_regs.h	hw/net/can/ctucafd: Add CTU CAN FD core register definitions.	2020-09-30 19:11:37 +02:00
ctucan_core.c	hw/net/can/ctucan: Avoid unused value in ctucan_send_ready_buffers()	2020-11-11 20:34:36 +08:00
ctucan_core.h	hw/net/can: CTU CAN FD IP open hardware core emulation.	2020-09-30 19:11:37 +02:00
ctucan_pci.c	hw/net/can: CTU CAN FD IP open hardware core emulation.	2020-09-30 19:11:37 +02:00
meson.build	hw/net/can: CTU CAN FD IP open hardware core emulation.	2020-09-30 19:11:37 +02:00