mirror of
				https://github.com/qemu/qemu.git
				synced 2025-10-31 04:06:46 +00:00 
			
		
		
		
	 828d651c58
			
		
	
	
		828d651c58
		
	
	
	
	
		
			
			A device shouldn't access its parent object which is QOM internal. Instead it should use type cast for this purporse. This patch fixes this issue for all NPCM7XX Devices. Signed-off-by: Hao Wu <wuhaotsh@google.com> Reviewed-by: Peter Maydell <peter.maydell@linaro.org> Message-id: 20210108190945.949196-7-wuhaotsh@google.com Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
		
			
				
	
	
		
			270 lines
		
	
	
		
			8.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			270 lines
		
	
	
		
			8.5 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * Nuvoton NPCM7xx System Global Control Registers.
 | |
|  *
 | |
|  * Copyright 2020 Google LLC
 | |
|  *
 | |
|  * This program is free software; you can redistribute it and/or modify it
 | |
|  * under the terms of the GNU General Public License as published by the
 | |
|  * Free Software Foundation; either version 2 of the License, or
 | |
|  * (at your option) any later version.
 | |
|  *
 | |
|  * This program is distributed in the hope that it will be useful, but WITHOUT
 | |
|  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | |
|  * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
 | |
|  * for more details.
 | |
|  */
 | |
| 
 | |
| #include "qemu/osdep.h"
 | |
| 
 | |
| #include "hw/misc/npcm7xx_gcr.h"
 | |
| #include "hw/qdev-properties.h"
 | |
| #include "migration/vmstate.h"
 | |
| #include "qapi/error.h"
 | |
| #include "qemu/cutils.h"
 | |
| #include "qemu/log.h"
 | |
| #include "qemu/module.h"
 | |
| #include "qemu/units.h"
 | |
| 
 | |
| #include "trace.h"
 | |
| 
 | |
| #define NPCM7XX_GCR_MIN_DRAM_SIZE   (128 * MiB)
 | |
| #define NPCM7XX_GCR_MAX_DRAM_SIZE   (2 * GiB)
 | |
| 
 | |
| enum NPCM7xxGCRRegisters {
 | |
|     NPCM7XX_GCR_PDID,
 | |
|     NPCM7XX_GCR_PWRON,
 | |
|     NPCM7XX_GCR_MFSEL1          = 0x0c / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_MFSEL2,
 | |
|     NPCM7XX_GCR_MISCPE,
 | |
|     NPCM7XX_GCR_SPSWC           = 0x038 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_INTCR,
 | |
|     NPCM7XX_GCR_INTSR,
 | |
|     NPCM7XX_GCR_HIFCR           = 0x050 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_INTCR2          = 0x060 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_MFSEL3,
 | |
|     NPCM7XX_GCR_SRCNT,
 | |
|     NPCM7XX_GCR_RESSR,
 | |
|     NPCM7XX_GCR_RLOCKR1,
 | |
|     NPCM7XX_GCR_FLOCKR1,
 | |
|     NPCM7XX_GCR_DSCNT,
 | |
|     NPCM7XX_GCR_MDLR,
 | |
|     NPCM7XX_GCR_SCRPAD3,
 | |
|     NPCM7XX_GCR_SCRPAD2,
 | |
|     NPCM7XX_GCR_DAVCLVLR        = 0x098 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_INTCR3,
 | |
|     NPCM7XX_GCR_VSINTR          = 0x0ac / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_MFSEL4,
 | |
|     NPCM7XX_GCR_CPBPNTR         = 0x0c4 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_CPCTL           = 0x0d0 / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_CP2BST,
 | |
|     NPCM7XX_GCR_B2CPNT,
 | |
|     NPCM7XX_GCR_CPPCTL,
 | |
|     NPCM7XX_GCR_I2CSEGSEL,
 | |
|     NPCM7XX_GCR_I2CSEGCTL,
 | |
|     NPCM7XX_GCR_VSRCR,
 | |
|     NPCM7XX_GCR_MLOCKR,
 | |
|     NPCM7XX_GCR_SCRPAD          = 0x013c / sizeof(uint32_t),
 | |
|     NPCM7XX_GCR_USB1PHYCTL,
 | |
|     NPCM7XX_GCR_USB2PHYCTL,
 | |
|     NPCM7XX_GCR_REGS_END,
 | |
| };
 | |
| 
 | |
| static const uint32_t cold_reset_values[NPCM7XX_GCR_NR_REGS] = {
 | |
|     [NPCM7XX_GCR_PDID]          = 0x04a92750,   /* Poleg A1 */
 | |
|     [NPCM7XX_GCR_MISCPE]        = 0x0000ffff,
 | |
|     [NPCM7XX_GCR_SPSWC]         = 0x00000003,
 | |
|     [NPCM7XX_GCR_INTCR]         = 0x0000035e,
 | |
|     [NPCM7XX_GCR_HIFCR]         = 0x0000004e,
 | |
|     [NPCM7XX_GCR_INTCR2]        = (1U << 19),   /* DDR initialized */
 | |
|     [NPCM7XX_GCR_RESSR]         = 0x80000000,
 | |
|     [NPCM7XX_GCR_DSCNT]         = 0x000000c0,
 | |
|     [NPCM7XX_GCR_DAVCLVLR]      = 0x5a00f3cf,
 | |
|     [NPCM7XX_GCR_SCRPAD]        = 0x00000008,
 | |
|     [NPCM7XX_GCR_USB1PHYCTL]    = 0x034730e4,
 | |
|     [NPCM7XX_GCR_USB2PHYCTL]    = 0x034730e4,
 | |
| };
 | |
| 
 | |
| static uint64_t npcm7xx_gcr_read(void *opaque, hwaddr offset, unsigned size)
 | |
| {
 | |
|     uint32_t reg = offset / sizeof(uint32_t);
 | |
|     NPCM7xxGCRState *s = opaque;
 | |
| 
 | |
|     if (reg >= NPCM7XX_GCR_NR_REGS) {
 | |
|         qemu_log_mask(LOG_GUEST_ERROR,
 | |
|                       "%s: offset 0x%04" HWADDR_PRIx " out of range\n",
 | |
|                       __func__, offset);
 | |
|         return 0;
 | |
|     }
 | |
| 
 | |
|     trace_npcm7xx_gcr_read(offset, s->regs[reg]);
 | |
| 
 | |
|     return s->regs[reg];
 | |
| }
 | |
| 
 | |
| static void npcm7xx_gcr_write(void *opaque, hwaddr offset,
 | |
|                               uint64_t v, unsigned size)
 | |
| {
 | |
|     uint32_t reg = offset / sizeof(uint32_t);
 | |
|     NPCM7xxGCRState *s = opaque;
 | |
|     uint32_t value = v;
 | |
| 
 | |
|     trace_npcm7xx_gcr_write(offset, value);
 | |
| 
 | |
|     if (reg >= NPCM7XX_GCR_NR_REGS) {
 | |
|         qemu_log_mask(LOG_GUEST_ERROR,
 | |
|                       "%s: offset 0x%04" HWADDR_PRIx " out of range\n",
 | |
|                       __func__, offset);
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     switch (reg) {
 | |
|     case NPCM7XX_GCR_PDID:
 | |
|     case NPCM7XX_GCR_PWRON:
 | |
|     case NPCM7XX_GCR_INTSR:
 | |
|         qemu_log_mask(LOG_GUEST_ERROR,
 | |
|                       "%s: register @ 0x%04" HWADDR_PRIx " is read-only\n",
 | |
|                       __func__, offset);
 | |
|         return;
 | |
| 
 | |
|     case NPCM7XX_GCR_RESSR:
 | |
|     case NPCM7XX_GCR_CP2BST:
 | |
|         /* Write 1 to clear */
 | |
|         value = s->regs[reg] & ~value;
 | |
|         break;
 | |
| 
 | |
|     case NPCM7XX_GCR_RLOCKR1:
 | |
|     case NPCM7XX_GCR_MDLR:
 | |
|         /* Write 1 to set */
 | |
|         value |= s->regs[reg];
 | |
|         break;
 | |
|     };
 | |
| 
 | |
|     s->regs[reg] = value;
 | |
| }
 | |
| 
 | |
| static const struct MemoryRegionOps npcm7xx_gcr_ops = {
 | |
|     .read       = npcm7xx_gcr_read,
 | |
|     .write      = npcm7xx_gcr_write,
 | |
|     .endianness = DEVICE_LITTLE_ENDIAN,
 | |
|     .valid      = {
 | |
|         .min_access_size        = 4,
 | |
|         .max_access_size        = 4,
 | |
|         .unaligned              = false,
 | |
|     },
 | |
| };
 | |
| 
 | |
| static void npcm7xx_gcr_enter_reset(Object *obj, ResetType type)
 | |
| {
 | |
|     NPCM7xxGCRState *s = NPCM7XX_GCR(obj);
 | |
| 
 | |
|     QEMU_BUILD_BUG_ON(sizeof(s->regs) != sizeof(cold_reset_values));
 | |
| 
 | |
|     switch (type) {
 | |
|     case RESET_TYPE_COLD:
 | |
|         memcpy(s->regs, cold_reset_values, sizeof(s->regs));
 | |
|         s->regs[NPCM7XX_GCR_PWRON] = s->reset_pwron;
 | |
|         s->regs[NPCM7XX_GCR_MDLR] = s->reset_mdlr;
 | |
|         s->regs[NPCM7XX_GCR_INTCR3] = s->reset_intcr3;
 | |
|         break;
 | |
|     }
 | |
| }
 | |
| 
 | |
| static void npcm7xx_gcr_realize(DeviceState *dev, Error **errp)
 | |
| {
 | |
|     ERRP_GUARD();
 | |
|     NPCM7xxGCRState *s = NPCM7XX_GCR(dev);
 | |
|     uint64_t dram_size;
 | |
|     Object *obj;
 | |
| 
 | |
|     obj = object_property_get_link(OBJECT(dev), "dram-mr", errp);
 | |
|     if (!obj) {
 | |
|         error_prepend(errp, "%s: required dram-mr link not found: ", __func__);
 | |
|         return;
 | |
|     }
 | |
|     dram_size = memory_region_size(MEMORY_REGION(obj));
 | |
|     if (!is_power_of_2(dram_size) ||
 | |
|         dram_size < NPCM7XX_GCR_MIN_DRAM_SIZE ||
 | |
|         dram_size > NPCM7XX_GCR_MAX_DRAM_SIZE) {
 | |
|         g_autofree char *sz = size_to_str(dram_size);
 | |
|         g_autofree char *min_sz = size_to_str(NPCM7XX_GCR_MIN_DRAM_SIZE);
 | |
|         g_autofree char *max_sz = size_to_str(NPCM7XX_GCR_MAX_DRAM_SIZE);
 | |
|         error_setg(errp, "%s: unsupported DRAM size %s", __func__, sz);
 | |
|         error_append_hint(errp,
 | |
|                           "DRAM size must be a power of two between %s and %s,"
 | |
|                           " inclusive.\n", min_sz, max_sz);
 | |
|         return;
 | |
|     }
 | |
| 
 | |
|     /* Power-on reset value */
 | |
|     s->reset_intcr3 = 0x00001002;
 | |
| 
 | |
|     /*
 | |
|      * The GMMAP (Graphics Memory Map) field is used by u-boot to detect the
 | |
|      * DRAM size, and is normally initialized by the boot block as part of DRAM
 | |
|      * training. However, since we don't have a complete emulation of the
 | |
|      * memory controller and try to make it look like it has already been
 | |
|      * initialized, the boot block will skip this initialization, and we need
 | |
|      * to make sure this field is set correctly up front.
 | |
|      *
 | |
|      * WARNING: some versions of u-boot only looks at bits 8 and 9, so 2 GiB of
 | |
|      * DRAM will be interpreted as 128 MiB.
 | |
|      *
 | |
|      * https://github.com/Nuvoton-Israel/u-boot/blob/2aef993bd2aafeb5408dbaad0f3ce099ee40c4aa/board/nuvoton/poleg/poleg.c#L244
 | |
|      */
 | |
|     s->reset_intcr3 |= ctz64(dram_size / NPCM7XX_GCR_MIN_DRAM_SIZE) << 8;
 | |
| }
 | |
| 
 | |
| static void npcm7xx_gcr_init(Object *obj)
 | |
| {
 | |
|     NPCM7xxGCRState *s = NPCM7XX_GCR(obj);
 | |
| 
 | |
|     memory_region_init_io(&s->iomem, obj, &npcm7xx_gcr_ops, s,
 | |
|                           TYPE_NPCM7XX_GCR, 4 * KiB);
 | |
|     sysbus_init_mmio(SYS_BUS_DEVICE(s), &s->iomem);
 | |
| }
 | |
| 
 | |
| static const VMStateDescription vmstate_npcm7xx_gcr = {
 | |
|     .name = "npcm7xx-gcr",
 | |
|     .version_id = 0,
 | |
|     .minimum_version_id = 0,
 | |
|     .fields = (VMStateField[]) {
 | |
|         VMSTATE_UINT32_ARRAY(regs, NPCM7xxGCRState, NPCM7XX_GCR_NR_REGS),
 | |
|         VMSTATE_END_OF_LIST(),
 | |
|     },
 | |
| };
 | |
| 
 | |
| static Property npcm7xx_gcr_properties[] = {
 | |
|     DEFINE_PROP_UINT32("disabled-modules", NPCM7xxGCRState, reset_mdlr, 0),
 | |
|     DEFINE_PROP_UINT32("power-on-straps", NPCM7xxGCRState, reset_pwron, 0),
 | |
|     DEFINE_PROP_END_OF_LIST(),
 | |
| };
 | |
| 
 | |
| static void npcm7xx_gcr_class_init(ObjectClass *klass, void *data)
 | |
| {
 | |
|     ResettableClass *rc = RESETTABLE_CLASS(klass);
 | |
|     DeviceClass *dc = DEVICE_CLASS(klass);
 | |
| 
 | |
|     QEMU_BUILD_BUG_ON(NPCM7XX_GCR_REGS_END > NPCM7XX_GCR_NR_REGS);
 | |
| 
 | |
|     dc->desc = "NPCM7xx System Global Control Registers";
 | |
|     dc->realize = npcm7xx_gcr_realize;
 | |
|     dc->vmsd = &vmstate_npcm7xx_gcr;
 | |
|     rc->phases.enter = npcm7xx_gcr_enter_reset;
 | |
| 
 | |
|     device_class_set_props(dc, npcm7xx_gcr_properties);
 | |
| }
 | |
| 
 | |
| static const TypeInfo npcm7xx_gcr_info = {
 | |
|     .name               = TYPE_NPCM7XX_GCR,
 | |
|     .parent             = TYPE_SYS_BUS_DEVICE,
 | |
|     .instance_size      = sizeof(NPCM7xxGCRState),
 | |
|     .instance_init      = npcm7xx_gcr_init,
 | |
|     .class_init         = npcm7xx_gcr_class_init,
 | |
| };
 | |
| 
 | |
| static void npcm7xx_gcr_register_type(void)
 | |
| {
 | |
|     type_register_static(&npcm7xx_gcr_info);
 | |
| }
 | |
| type_init(npcm7xx_gcr_register_type);
 |