mirror of
https://github.com/qemu/qemu.git
synced 2025-10-28 06:54:53 +00:00
a83c284490
vmstate_acpi_pcihp_use_acpi_index() was expecting AcpiPciHpState
as state but it actually received PIIX4PMState, because
VMSTATE_PCI_HOTPLUG is a macro and not another struct.
So it ended up accessing random pointer, which resulted
in 'false' return value and acpi_index field wasn't ever
sent.
However in 7.0 that pointer de-references to value > 0, and
destination QEMU starts to expect the field which isn't
sent in migratioon stream from older QEMU (6.2 and older).
As result migration fails with:
qemu-system-x86_64: Missing section footer for 0000:00:01.3/piix4_pm
qemu-system-x86_64: load of migration failed: Invalid argument
In addition with QEMU-6.2, destination due to not expected
state, also never expects the acpi_index field in migration
stream.
Q35 is not affected as it always sends/expects the field as
long as acpi based PCI hotplug is enabled.
Fix issue by introducing compat knob to never send/expect
acpi_index in migration stream for 6.2 and older PC machine
types and always send it for 7.0 and newer PC machine types.
Diagnosed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixes:
|
||
|---|---|---|
| .. | ||
| acpi_interface.c | ||
| acpi-cpu-hotplug-stub.c | ||
| acpi-mem-hotplug-stub.c | ||
| acpi-nvdimm-stub.c | ||
| acpi-pci-hotplug-stub.c | ||
| acpi-stub.c | ||
| acpi-x86-stub.c | ||
| aml-build-stub.c | ||
| aml-build.c | ||
| bios-linker-loader.c | ||
| core.c | ||
| cpu_hotplug.c | ||
| cpu.c | ||
| erst.c | ||
| generic_event_device.c | ||
| ghes-stub.c | ||
| ghes.c | ||
| hmat.c | ||
| hmat.h | ||
| ich9.c | ||
| ipmi-stub.c | ||
| ipmi.c | ||
| Kconfig | ||
| memory_hotplug.c | ||
| meson.build | ||
| nvdimm.c | ||
| pci.c | ||
| pcihp.c | ||
| piix4.c | ||
| tco.c | ||
| tpm.c | ||
| trace-events | ||
| trace.h | ||
| utils.c | ||
| viot.c | ||
| viot.h | ||
| vmgenid.c | ||